mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>, Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Gabriel C <nix.or.die@gmail.com>
Subject: Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm
Date: Sat, 22 Oct 2016 15:08:52 -0400	[thread overview]
Message-ID: <20161022150852.0e54e763@gandalf.local.home> (raw)
In-Reply-To: <20161022104441.6a8f442f@roar.ozlabs.ibm.com>

On Sat, 22 Oct 2016 10:44:41 +1100
Nicholas Piggin <npiggin@gmail.com> wrote:

> >  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
> > diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
> > index 43199a049da5..cb86e746865e 100644
> > --- a/include/asm-generic/export.h
> > +++ b/include/asm-generic/export.h
> > @@ -90,5 +90,10 @@
> >  	__EXPORT_SYMBOL(name, KSYM(name),)
> >  #define EXPORT_DATA_SYMBOL_GPL(name)				\
> >  	__EXPORT_SYMBOL(name, KSYM(name),_gpl)
> > +/*
> > + * If "name" is a macro of a function and not a function itself,
> > + * it needs a second pass.
> > + */
> > +#define EXPORT_MACRO_SYMBOL(x) EXPORT_SYMBOL(x)  
> 
> Seems okay, but what about just calling it EXPORT_SYMBOL?


Actually, this doesn't work. There's some magic going on it
Makefile.build in the scripts directory that causes this to fail.

I have another patch I'll be sending on Monday that fixes this.

-- Steve

  reply	other threads:[~2016-10-22 19:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 16:17 Steven Rostedt
2016-10-21 23:44 ` Nicholas Piggin
2016-10-22 19:08   ` Steven Rostedt [this message]
2016-10-24  1:25     ` Nicholas Piggin
2016-10-24 14:14       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161022150852.0e54e763@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nix.or.die@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®