From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
bhaktipriya96@gmail.com, rkrcmar@redhat.com,
stable@vger.kernel.org
Subject: Re: [PATCH] KVM: fix OOPS on flush_work
Date: Wed, 26 Oct 2016 14:02:06 +0200 [thread overview]
Message-ID: <20161026140206.73cb1150.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1477482290-18464-1-git-send-email-pbonzini@redhat.com>
On Wed, 26 Oct 2016 13:44:50 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> The conversion done by commit 3706feacd007 ("KVM: Remove deprecated
> create_singlethread_workqueue") is broken. It flushes a single work
> item &irqfd->shutdown instead of all of them, and even worse if there
> is no irqfd on the list then you get a NULL pointer dereference.
> Revert the virt/kvm/eventfd.c part of that patch; to avoid the
> deprecated function, just allocate our own workqueue---it does
> not even have to be unbound---with alloc_workqueue.
>
> Fixes: 3706feacd007
> Cc: stable@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> virt/kvm/eventfd.c | 22 +++++++++++++++++++---
> virt/kvm/kvm_main.c | 6 ++++++
> 2 files changed, 25 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
prev parent reply other threads:[~2016-10-26 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 11:44 Paolo Bonzini
2016-10-26 12:02 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026140206.73cb1150.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=bhaktipriya96@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®