From: Naeil ZOUEIDI <naeilzoueidi@ubuntu.com>
To: gregkh@linuxfoundation.org, bankarsandhya512@gmail.com,
isdn@linux-pingi.de, sudipm.mukherjee@gmail.com, arnd@arndb.de,
ansonjacob.aj@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Naeil ZOUEIDI <naeilzoueidi@ubuntu.com>
Subject: [PATCH] This is a patch to the capi.c file that fixes one instance of the following error: ERROR: do not use assignment in if condition
Date: Sun, 6 Nov 2016 09:55:15 +0100 [thread overview]
Message-ID: <20161106085515.24141-1-naeilzoueidi@ubuntu.com> (raw)
Staging: i4l: act200:
Signed-off-by: Naeil Zoueidi <naeilzoueidi@ubuntu.com>
---
drivers/staging/i4l/act2000/capi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/i4l/act2000/capi.c b/drivers/staging/i4l/act2000/capi.c
index 62f5629..b494917 100644
--- a/drivers/staging/i4l/act2000/capi.c
+++ b/drivers/staging/i4l/act2000/capi.c
@@ -564,7 +564,8 @@ actcapi_data_b3_ind(act2000_card *card, struct sk_buff *skb) {
blocknr = msg->msg.data_b3_ind.blocknr;
skb_pull(skb, 19);
card->interface.rcvcallb_skb(card->myid, chan, skb);
- if (!(skb = alloc_skb(11, GFP_ATOMIC))) {
+ skb = alloc_skb(11, GFP_ATOMIC;
+ if (!skb) {
printk(KERN_WARNING "actcapi: alloc_skb failed\n");
return 1;
}
--
2.10.1
next reply other threads:[~2016-11-06 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 8:55 Naeil ZOUEIDI [this message]
2016-11-06 9:28 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161106085515.24141-1-naeilzoueidi@ubuntu.com \
--to=naeilzoueidi@ubuntu.com \
--cc=ansonjacob.aj@gmail.com \
--cc=arnd@arndb.de \
--cc=bankarsandhya512@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®