From: Peter Zijlstra <peterz@infradead.org>
To: David Windsor <dave@progbits.org>
Cc: kernel-hardening@lists.openwall.com,
Will Deacon <will.deacon@arm.com>,
Greg KH <gregkh@linuxfoundation.org>,
Elena Reshetova <elena.reshetova@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <h.peter.anvin@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [kernel-hardening] Re: [RFC v4 PATCH 00/13] HARDENED_ATOMIC
Date: Thu, 10 Nov 2016 22:39:52 +0100 [thread overview]
Message-ID: <20161110213952.GB3117@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAEXv5_i3Ju5JNs6g-jA-WkMR38g43Aj5we0+GXeHcuUAM3nziQ@mail.gmail.com>
On Thu, Nov 10, 2016 at 04:23:08PM -0500, David Windsor wrote:
> Discussions have been occurring since KSPP has begun: do we need a
Note that I was not included in any of that. If you hide in a corner on
the intartubes don't be surprised people have no clue what you're on
about.
> specialized type for reference counters? Oh, wait, we do: kref.
> Wait! kref is implemented with atomic_t.
>
> So, what? We obviously need an atomicity for a reference counter
> type. So, do we simply implement the HARDENED_ATOMIC protected
> version of atomic_t "inside" of kref and leave atomic_t alone?
But you could provide a small subset of the atomic_t API for that, under
a different type.
That way you don't get utter shite like atomic_cmpxchg_wrap() for
instance.
>From what I can see only all the add/sub variants have overflow checks,
but all the operations get _wrap() prefixes, even where it doesn't make
any bloody sense. _wrap() on bitops?, _wrap() on cmpxchg(). You must be
bloody joking right?
next prev parent reply other threads:[~2016-11-10 21:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1478809488-18303-1-git-send-email-elena.reshetova@intel.com>
2016-11-10 20:37 ` Peter Zijlstra
2016-11-10 20:48 ` Will Deacon
2016-11-10 21:01 ` Kees Cook
2016-11-10 21:23 ` [kernel-hardening] " David Windsor
2016-11-10 21:27 ` Kees Cook
2016-11-10 21:39 ` David Windsor
2016-11-10 21:39 ` Peter Zijlstra [this message]
2016-11-10 21:13 ` Peter Zijlstra
2016-11-10 21:23 ` Kees Cook
2016-11-11 4:25 ` [kernel-hardening] " Rik van Riel
2016-11-10 22:27 ` Greg KH
2016-11-10 23:15 ` Kees Cook
2016-11-10 23:38 ` Greg KH
2016-11-10 23:57 ` Peter Zijlstra
2016-11-11 0:29 ` Colin Vidal
2016-11-11 12:41 ` Mark Rutland
2016-11-11 12:47 ` Peter Zijlstra
2016-11-11 13:00 ` Peter Zijlstra
2016-11-11 14:39 ` Thomas Gleixner
2016-11-11 14:48 ` Peter Zijlstra
2016-11-11 23:07 ` Peter Zijlstra
2016-11-13 11:03 ` Greg KH
2016-11-10 20:56 ` Kees Cook
2016-11-11 3:20 ` [kernel-hardening] " David Windsor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110213952.GB3117@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=dave@progbits.org \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=h.peter.anvin@intel.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®