From: "Theodore Ts'o" <tytso@mit.edu>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, arnd@arndb.de,
y2038@lists.linaro.org
Subject: Re: [RESEND] fs: ext4: Use current_time() for inode timestamps
Date: Mon, 14 Nov 2016 21:53:20 -0500 [thread overview]
Message-ID: <20161115025320.oax4e56om5zcjynt@thunk.org> (raw)
In-Reply-To: <1478889177-4107-1-git-send-email-deepa.kernel@gmail.com>
On Fri, Nov 11, 2016 at 10:32:57AM -0800, Deepa Dinamani wrote:
> CURRENT_TIME_SEC and CURRENT_TIME are not y2038 safe.
> current_time() will be transitioned to be y2038 safe
> along with vfs.
>
> current_time() returns timestamps according to the
> granularities set in the super_block.
> The granularity check in ext4_current_time() to call
> current_time() or CURRENT_TIME_SEC is not required.
> Use current_time() directly to obtain timestamps
> unconditionally, and remove ext4_current_time().
>
> Quota files are assumed to be on the same filesystem.
> Hence, use current_time() for these files as well.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied.
- Ted
prev parent reply other threads:[~2016-11-15 2:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 18:32 [RESEND PATCH] " Deepa Dinamani
2016-11-15 2:53 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115025320.oax4e56om5zcjynt@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome