From: Mark Brown <broonie@kernel.org>
To: prahlad venkata <prahlad.eee@gmail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Vignesh R <vigneshr@ti.com>
Subject: Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable
Date: Tue, 22 Nov 2016 12:27:41 +0000 [thread overview]
Message-ID: <20161122122741.vo5e6udfkda5ke5d@sirena.org.uk> (raw)
In-Reply-To: <CAFbo-qWmvm02wpkWT0hgX6qu6jOStmwAXHBWbjbAQ=fwv0WPng@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Tue, Nov 22, 2016 at 12:54:06PM +0530, prahlad venkata wrote:
> Did anybody got chance to review this patch?
> I feel this is a trivial yet required fix.
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, though there are some other maintainers who like them - if in
doubt look at how patches for the subsystem are normally handled.
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2016-11-22 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 18:26 Prahlad V
2016-11-15 18:53 ` Applied "spi: spi-ti-qspi: reinit of completion variable" to the spi tree Mark Brown
2016-11-22 7:24 ` [PATCH] spi: spi-ti-qspi: reinit of completion variable prahlad venkata
2016-11-22 12:27 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122122741.vo5e6udfkda5ke5d@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=prahlad.eee@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®