mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Pan Bian <bianpan201604@163.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pan Bian <bianpan2016@163.com>
Subject: Re: [PATCH 1/1] edac: fix improper return value
Date: Sun, 4 Dec 2016 11:07:34 +0100	[thread overview]
Message-ID: <20161204100734.glm3eutpsw3h22fm@pd.tnic> (raw)
In-Reply-To: <1480831638-5361-1-git-send-email-bianpan201604@163.com>

On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote:
> From: Pan Bian <bianpan2016@163.com>
> 
> When the call to zalloc_cpumask_var() fails, returning "false" seems
> improper. The real value of macro "false" is 0, and 0 means no error.
> This patch fixes the bug, returning "-ENOMEM".
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071

That bugzilla entry wasn't really needed.

> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  drivers/edac/amd64_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied,
thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

      reply	other threads:[~2016-12-04 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-04  6:07 Pan Bian
2016-12-04 10:07 ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161204100734.glm3eutpsw3h22fm@pd.tnic \
    --to=bp@alien8.de \
    --cc=bianpan201604@163.com \
    --cc=bianpan2016@163.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®