Re: [PATCH 1/3] USB: OHCI: at91: remove useless extern declaration

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* Re: [PATCH 1/3] USB: OHCI: at91: remove useless extern declaration
       [not found] ` <1480735523-23950-2-git-send-email-csmanjuvijay@gmail.com>
@ 2016-12-05 14:10   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-12-05 14:10 UTC (permalink / raw)
  To: csmanjuvijay; +Cc: Alan Stern, linux-usb, linux-kernel

On Sat, Dec 03, 2016 at 03:25:21AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration in drivers/usb/core/usb.c

The EXPORT_SYMBOL_GPL() has nothing to do with this, it's the fact that
it is exported in include/linux/usb.h that matters.

Please fix the text up and resend.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <1480735523-23950-3-git-send-email-csmanjuvijay@gmail.com>]

* Re: [PATCH 2/3] USB: OHCI: omap: remove useless extern declaration
       [not found] ` <1480735523-23950-3-git-send-email-csmanjuvijay@gmail.com>
@ 2016-12-05 14:10   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-12-05 14:10 UTC (permalink / raw)
  To: csmanjuvijay; +Cc: Alan Stern, linux-usb, linux-omap, linux-kernel

On Sat, Dec 03, 2016 at 03:25:22AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() and ocpi_enable() extern declaration
> as it is already declared as EXPORT_SYMBOL_GPL declaration.

Same here, EXPORT_SYMBOL* doesn't matter for stuff like this.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <1480735523-23950-4-git-send-email-csmanjuvijay@gmail.com>]

* Re: [PATCH 3/3] USB: OHCI: nxp: remove useless extern declaration
       [not found] ` <1480735523-23950-4-git-send-email-csmanjuvijay@gmail.com>
@ 2016-12-05 14:11   ` Greg Kroah-Hartman
  2016-12-05 14:12   ` Greg Kroah-Hartman
  1 sibling, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-12-05 14:11 UTC (permalink / raw)
  To: csmanjuvijay
  Cc: Vladimir Zapolskiy, Sylvain Lemieux, Alan Stern,
	linux-arm-kernel, linux-usb, linux-kernel

On Sat, Dec 03, 2016 at 03:25:23AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration.

And same thing again...

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 3/3] USB: OHCI: nxp: remove useless extern declaration
       [not found] ` <1480735523-23950-4-git-send-email-csmanjuvijay@gmail.com>
  2016-12-05 14:11   ` [PATCH 3/3] USB: OHCI: nxp: " Greg Kroah-Hartman
@ 2016-12-05 14:12   ` Greg Kroah-Hartman
  1 sibling, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-12-05 14:12 UTC (permalink / raw)
  To: csmanjuvijay
  Cc: Vladimir Zapolskiy, Sylvain Lemieux, Alan Stern,
	linux-arm-kernel, linux-usb, linux-kernel

On Sat, Dec 03, 2016 at 03:25:23AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as EXPORT_SYMBOL_GPL declaration.

merge this with your first patch please, it belongs with it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

[parent not found: <1481150056-3623-1-git-send-email-csmanjuvijay@gmail.com>]

[parent not found: <1481150056-3623-4-git-send-email-csmanjuvijay@gmail.com>]

* Re: [PATCH v2 3/3] USB: OHCI: nxp: remove useless extern declaration
       [not found]   ` <1481150056-3623-4-git-send-email-csmanjuvijay@gmail.com>
@ 2016-12-08  1:35     ` Vladimir Zapolskiy
  0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Zapolskiy @ 2016-12-08  1:35 UTC (permalink / raw)
  To: csmanjuvijay, Greg Kroah-Hartman
  Cc: Sylvain Lemieux, Alan Stern, linux-arm-kernel, linux-usb, linux-kernel

On 12/08/2016 12:34 AM, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> Remove usb_disabled() extern declaration as it is already declared
> as extern in include/linux/usb.h.
> 
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Sylvain Lemieux <slemieux.tyco@gmail.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> changelog V1->V2:
> patch discrition is update with proper message.
> 

I'm fine with the change, thank you for the clean-up.

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

--
With best wishes,
Vladimir

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-12-08  1:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1480735523-23950-1-git-send-email-csmanjuvijay@gmail.com>
     [not found] ` <1480735523-23950-2-git-send-email-csmanjuvijay@gmail.com>
2016-12-05 14:10   ` [PATCH 1/3] USB: OHCI: at91: remove useless extern declaration Greg Kroah-Hartman
     [not found] ` <1480735523-23950-3-git-send-email-csmanjuvijay@gmail.com>
2016-12-05 14:10   ` [PATCH 2/3] USB: OHCI: omap: " Greg Kroah-Hartman
     [not found] ` <1480735523-23950-4-git-send-email-csmanjuvijay@gmail.com>
2016-12-05 14:11   ` [PATCH 3/3] USB: OHCI: nxp: " Greg Kroah-Hartman
2016-12-05 14:12   ` Greg Kroah-Hartman
     [not found] ` <1481150056-3623-1-git-send-email-csmanjuvijay@gmail.com>
     [not found]   ` <1481150056-3623-4-git-send-email-csmanjuvijay@gmail.com>
2016-12-08  1:35     ` [PATCH v2 " Vladimir Zapolskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome