From: Michal Hocko <mhocko@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Stable tree <stable@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>, Willy Tarreau <w@1wt.eu>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [RFC PATCH] doc: change the way how the stable backport is requested
Date: Mon, 5 Dec 2016 15:39:15 +0100 [thread overview]
Message-ID: <20161205143915.GN30758@dhcp22.suse.cz> (raw)
In-Reply-To: <20161205142137.GA4332@kroah.com>
On Mon 05-12-16 15:21:37, Greg KH wrote:
> On Mon, Dec 05, 2016 at 03:14:51PM +0100, Michal Hocko wrote:
> > On Mon 05-12-16 14:58:24, Greg KH wrote:
> > > On Mon, Dec 05, 2016 at 02:05:08PM +0100, Michal Hocko wrote:
> > > > On Mon 05-12-16 13:52:36, Greg KH wrote:
> > > > > On Mon, Dec 05, 2016 at 08:21:54AM +0100, Michal Hocko wrote:
> > > > > > From: Michal Hocko <mhocko@suse.com>
> > > > > >
> > > > > > Currently if a patch should aim a stable tree backport one should add
> > > > > >
> > > > > > Cc: stable@vger.kernel.org # $version
> > > > > >
> > > > > > to the s-o-b block. This has two major disadvantages a) it spams the
> > > > > > stable mailing list with patches which are just discussed and not merged
> > > > > > yet
> > > > >
> > > > > That's not a problem in that I know I like to see them to give me a
> > > > > "heads up" that something is coming down the pipeline soon.
> > > >
> > > > Are you really tracking all those discussion to catch resulting patches
> > > > in the Linus' tree? I simply fail to see a point having N versions of
> > > > the patch on the stable mailing list before it gets picked up from the
> > > > _Linus'_ anyayw.
> > >
> > > I do scan them, sometimes I even find problems with them (like a zram
> > > "fix" that went by this weekend.) So yes, it is always good to have
> > > more reviewers on patches, don't you think?
> >
> > Yes I do agree that more review is better. But then the stable mailing
> > list is a complete failure in that resopect - at least for me. Why?
> > Simply because it doesn't contain discussion for the stable inclusion
> > but rather something that eventually might happen to become stable
> > material. This what I call noise and the reason why I've stopped
> > following the stable ML.
>
> That doesn't make sense, I want to see patches that are being proposed
> for the stable kernels _before_ they get into the maintainers and
> Linus's tree, as then, it is almost always too late.
Too late for what? I am still not sure I see your point. Are you
suggesting that a review from the stable mailing list, which wouldn't
be a part of a standard review process normally, has helped to identify
issues?
> I will point out the zram patch this weekend as an example of that,
> where if the original had gone in, it would be a while before the
> "fixup" would have then gone in, and the abi deprecation would probably
> have missed 4.11 entirely.
I do not have a full context here. Do you have a pointer please?
> Don't you want to catch things earlier rather than later?
Sure, but I fail to see the role of the stable ML in this area. I might
be underastimating its role of course.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-12-05 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 7:21 Michal Hocko
2016-12-05 12:52 ` Greg KH
2016-12-05 13:05 ` Michal Hocko
2016-12-05 13:15 ` Willy Tarreau
2016-12-05 13:24 ` Michal Hocko
2016-12-05 13:30 ` Willy Tarreau
2016-12-05 13:58 ` Greg KH
2016-12-05 14:14 ` Michal Hocko
2016-12-05 14:21 ` Greg KH
2016-12-05 14:39 ` Michal Hocko [this message]
2016-12-05 14:43 ` Greg KH
2016-12-05 14:56 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205143915.GN30758@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=stable@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®