From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Emil Bartczak <emilbart@gmail.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] rtc: mcp795: use bcd2bin/bin2bcd.
Date: Mon, 5 Dec 2016 16:27:52 +0100 [thread overview]
Message-ID: <20161205152752.btnbja25daxn2dha@piout.net> (raw)
In-Reply-To: <1c3a3f47c0316b2bf02e762d0990de1aab23d828.1480939487.git.emilbart@gmail.com>
On 05/12/2016 at 14:11:53 +0100, Emil Bartczak wrote :
> Change rtc-mcp795.c to use the bcd2bin/bin2bcd functions.
> ---
> drivers/rtc/rtc-mcp795.c | 28 +++++++++++++---------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc-mcp795.c
> index c9ad46c..1d823f9 100644
> --- a/drivers/rtc/rtc-mcp795.c
> +++ b/drivers/rtc/rtc-mcp795.c
> @@ -22,6 +22,7 @@
> #include <linux/rtc.h>
> #include <linux/of.h>
> #include <linux/delay.h>
> +#include <linux/bcd.h>
>
> /* MCP795 Instructions, see datasheet table 3-1 */
> #define MCP795_EEREAD 0x03
> @@ -137,7 +138,6 @@ static int mcp795_start_oscillator(struct device *dev)
>
> static int mcp795_set_time(struct device *dev, struct rtc_time *tim)
> {
> - int month;
You just introduced this variable to fix a bug. Maybe it was not necessary?
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-12-05 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 13:11 [PATCH 0/4] Provides bug fixes for rtc-mcp795.c Emil Bartczak
2016-12-05 13:11 ` [PATCH 1/4] rtc: mcp795: fix invalid month setting Emil Bartczak
2016-12-05 15:09 ` Alexandre Belloni
2016-12-05 22:03 ` Emil Bartczak
2016-12-05 22:15 ` Alexandre Belloni
2016-12-05 22:31 ` Emil Bartczak
2016-12-05 13:11 ` [PATCH 2/4] rtc: mcp795: fix time range difference between linux and RTC chip Emil Bartczak
2016-12-05 13:11 ` [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1 Emil Bartczak
2016-12-05 15:24 ` Alexandre Belloni
2016-12-05 22:16 ` Emil Bartczak
2016-12-05 22:47 ` Alexandre Belloni
2016-12-05 13:11 ` [PATCH 4/4] rtc: mcp795: use bcd2bin/bin2bcd Emil Bartczak
2016-12-05 15:27 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205152752.btnbja25daxn2dha@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=emilbart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®