mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver core: flush async calls before testing driver removal
Date: Mon, 12 Dec 2016 13:46:09 -0500	[thread overview]
Message-ID: <20161212184609.GH13864@htj.duckdns.org> (raw)
In-Reply-To: <CAL_JsqKxyynTTH1C0o34E93278-CS8CrQfq5dvxWPZ0QkZBs+Q@mail.gmail.com>

Hello,

On Mon, Dec 12, 2016 at 12:33:36PM -0600, Rob Herring wrote:
> Maybe I'm confused, but don't you need this for all drivers? You need
> sync the async SCSI scanning to the driver remove regardless of async
> probe. The driver core synchronization is only for synchronizing the
> remove with probe AIUI.

Heh, I'm not quite following what you mean.  Can you please elaborate?
Also, on the second thought, it probably would be better to flush
async calls before unbind.  It's fragile to require indivdiual drivers
to do that and I can't think of benefits of doing so.  It's not like
the unbind / unload paths are hot in any way.

Thanks.

-- 
tejun

      reply	other threads:[~2016-12-12 18:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-10  0:15 Vladimir Zapolskiy
2016-12-10  1:59 ` Dmitry Torokhov
2016-12-10 12:57   ` Vladimir Zapolskiy
2016-12-10  7:32 ` Greg Kroah-Hartman
2016-12-10 12:38   ` Vladimir Zapolskiy
2016-12-10 13:04     ` Greg Kroah-Hartman
2016-12-11  1:44       ` Vladimir Zapolskiy
2016-12-12 17:50         ` Tejun Heo
2016-12-12 18:33           ` Rob Herring
2016-12-12 18:46             ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161212184609.GH13864@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome