[PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

[PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

[Geert Uytterhoeven]

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index cb6c7def29b26f15..f5c7915a23bc2417 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -378,6 +378,7 @@ config SPI_FSL_SPI
 config SPI_FSL_DSPI
 	tristate "Freescale DSPI controller"
 	select REGMAP_MMIO
+	depends on HAS_DMA
 	depends on SOC_VF610 || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
 	help
 	  This enables support for the Freescale DSPI controller in master
-- 
1.9.1

Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Wed, Dec 14, 2016 at 01:28:05PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:

>     ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!

> Add a dependency on HAS_DMA to fix this.

Honestly I think we should just fix the architectures that don't support
DMA to provide compile out stubs for DMA, it seems like these
dependencies are more trouble than they're worth.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

[Geert Uytterhoeven]

Hi Mark,

On Wed, Dec 14, 2016 at 3:37 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Dec 14, 2016 at 01:28:05PM +0100, Geert Uytterhoeven wrote:
>> If NO_DMA=y:
>
>>     ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!
>
>> Add a dependency on HAS_DMA to fix this.
>
> Honestly I think we should just fix the architectures that don't support
> DMA to provide compile out stubs for DMA, it seems like these
> dependencies are more trouble than they're worth.

Will that really help?

Then people will start adding "depends on HAS_DMA || COMPILE_TEST"
instead...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Wed, Dec 14, 2016 at 03:40:43PM +0100, Geert Uytterhoeven wrote:
> On Wed, Dec 14, 2016 at 3:37 PM, Mark Brown <broonie@kernel.org> wrote:
> > On Wed, Dec 14, 2016 at 01:28:05PM +0100, Geert Uytterhoeven wrote:

> > Honestly I think we should just fix the architectures that don't support
> > DMA to provide compile out stubs for DMA, it seems like these
> > dependencies are more trouble than they're worth.

> Will that really help?

> Then people will start adding "depends on HAS_DMA || COMPILE_TEST"
> instead...

No, I'm thinking just arrange things so that we don't need to depend on
HAS_DMA at all.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Applied "spi: SPI_FSL_DSPI should depend on HAS_DMA" to the spi tree

[Mark Brown]

The patch

   spi: SPI_FSL_DSPI should depend on HAS_DMA

has been applied to the spi tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From dadab2d4e3cf708ceba22ecddd94aedfecb39199 Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 14 Dec 2016 13:28:05 +0100
Subject: [PATCH] spi: SPI_FSL_DSPI should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/spi/spi-fsl-dspi.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index ec4aa252d6e8..2922a9908302 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -378,6 +378,7 @@ config SPI_FSL_SPI
 config SPI_FSL_DSPI
 	tristate "Freescale DSPI controller"
 	select REGMAP_MMIO
+	depends on HAS_DMA
 	depends on SOC_VF610 || SOC_LS1021A || ARCH_LAYERSCAPE || COMPILE_TEST
 	help
 	  This enables support for the Freescale DSPI controller in master
-- 
2.11.0