From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Hurley <peter@hurleysoftware.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: [PATCH 0/2] printk: always report dropped messages
Date: Sat, 24 Dec 2016 23:09:00 +0900 [thread overview]
Message-ID: <20161224140902.1962-1-sergey.senozhatsky@gmail.com> (raw)
Hello,
Two patches: trivial clean up and console_unlock() "fix".
The `printk messages dropped' report is printed as part of actual
kernel message, that's why we do 'text + len, sizeof(text) - len'
later in msg_print_text().
The problem here is that we may eventually skip the message, and
thus lose the 'printk messages dropped' report, if `console_loglevel'
check tells us to do so. Missing kernel messages in serial log
together with the missing 'printk messages dropped' can be quite
confusing.
There are two options to address it:
a) forbid suppress_message_printing() if we know that we must print
`printk messages dropped'
b) print `printk messages dropped' as a standalone message.
Sergey Senozhatsky (2):
printk: drop call_console_drivers() unused param
printk: always report lost messages on serial console
kernel/printk/printk.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
--
2.11.0
next reply other threads:[~2016-12-24 14:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 14:09 Sergey Senozhatsky [this message]
2016-12-24 14:09 ` [PATCH 1/2] printk: drop call_console_drivers() unused param Sergey Senozhatsky
2017-01-03 10:22 ` Petr Mladek
2017-01-09 13:49 ` Petr Mladek
2016-12-24 14:09 ` [PATCH 2/2] printk: always report lost messages on serial console Sergey Senozhatsky
2017-01-03 14:55 ` Petr Mladek
2017-01-03 15:47 ` Sergey Senozhatsky
2017-01-03 16:53 ` Petr Mladek
2017-01-04 2:46 ` Sergey Senozhatsky
2017-01-04 10:52 ` Petr Mladek
2017-01-04 13:34 ` Sergey Senozhatsky
2017-01-04 15:26 ` Petr Mladek
2017-01-05 2:30 ` Sergey Senozhatsky
2017-01-05 10:53 ` Petr Mladek
2017-01-09 16:56 ` Petr Mladek
2017-01-10 8:49 ` Sergey Senozhatsky
2017-01-11 16:50 ` Petr Mladek
2017-01-13 5:11 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161224140902.1962-1-sergey.senozhatsky@gmail.com \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®