From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Hurley <peter@hurleysoftware.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: [PATCH 2/2] printk: always report lost messages on serial console
Date: Sat, 24 Dec 2016 23:09:02 +0900 [thread overview]
Message-ID: <20161224140902.1962-3-sergey.senozhatsky@gmail.com> (raw)
In-Reply-To: <20161224140902.1962-1-sergey.senozhatsky@gmail.com>
The "printk messages dropped" report is 'attached' to a kernel
message located at console_idx offset. This does not work well
if we skip that message due to loglevel filtering, because in
this case we also skip/lose dropped message report.
Disable suppress_message_printing() loglevel filtering if we
must report "printk messages dropped" condition.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
kernel/printk/printk.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 11a9842a2f47..6a7ebcb0bb6e 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2218,6 +2218,7 @@ void console_unlock(void)
struct printk_log *msg;
size_t ext_len = 0;
size_t len;
+ bool report_dropped_msg = false;
raw_spin_lock_irqsave(&logbuf_lock, flags);
if (seen_seq != log_next_seq) {
@@ -2232,6 +2233,7 @@ void console_unlock(void)
/* messages are gone, move to first one */
console_seq = log_first_seq;
console_idx = log_first_idx;
+ report_dropped_msg = true;
} else {
len = 0;
}
@@ -2240,7 +2242,8 @@ void console_unlock(void)
break;
msg = log_from_idx(console_idx);
- if (suppress_message_printing(msg->level)) {
+ if (!report_dropped_msg &&
+ suppress_message_printing(msg->level)) {
/*
* Skip record we have buffered and already printed
* directly to the console when we received it, and
--
2.11.0
next prev parent reply other threads:[~2016-12-24 14:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 14:09 [PATCH 0/2] printk: always report dropped messages Sergey Senozhatsky
2016-12-24 14:09 ` [PATCH 1/2] printk: drop call_console_drivers() unused param Sergey Senozhatsky
2017-01-03 10:22 ` Petr Mladek
2017-01-09 13:49 ` Petr Mladek
2016-12-24 14:09 ` Sergey Senozhatsky [this message]
2017-01-03 14:55 ` [PATCH 2/2] printk: always report lost messages on serial console Petr Mladek
2017-01-03 15:47 ` Sergey Senozhatsky
2017-01-03 16:53 ` Petr Mladek
2017-01-04 2:46 ` Sergey Senozhatsky
2017-01-04 10:52 ` Petr Mladek
2017-01-04 13:34 ` Sergey Senozhatsky
2017-01-04 15:26 ` Petr Mladek
2017-01-05 2:30 ` Sergey Senozhatsky
2017-01-05 10:53 ` Petr Mladek
2017-01-09 16:56 ` Petr Mladek
2017-01-10 8:49 ` Sergey Senozhatsky
2017-01-11 16:50 ` Petr Mladek
2017-01-13 5:11 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161224140902.1962-3-sergey.senozhatsky@gmail.com \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®