* [PATCH v2] leds: add LED_ON brightness as boolean value [not found] <CGME20170105023420epcas1p28624575ab6619e1930ebc05795725d90@epcas1p2.samsung.com> @ 2017-01-05 2:34 ` Andi Shyti 2017-01-05 22:17 ` Jacek Anaszewski 0 siblings, 1 reply; 2+ messages in thread From: Andi Shyti @ 2017-01-05 2:34 UTC (permalink / raw) To: Richard Purdie, Jacek Anaszewski, Pavel Machek Cc: Jaechul Lee, linux-leds, linux-kernel, Andi Shyti, Andi Shyti Some devices do not handle the led brightness or simply don't care about it. Conceptually said devices want to just switch on or off the led. It is useless in this case to have a 255 range of brightness, while just having an LED_ON and LED_OFF improves the boolean meaning of the led status. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> Acked-by: Pavel Machek <pavel@ucw.cz> --- Hi, Thanks Pavel and Jacek for your review. Differences from V1 - used explicit assignement of LED_ON in the enum - added Pavel's ack Andi include/linux/leds.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/leds.h b/include/linux/leds.h index 569cb531094c..bb50d0151e75 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -27,6 +27,7 @@ struct device; enum led_brightness { LED_OFF = 0, + LED_ON = 1, LED_HALF = 127, LED_FULL = 255, }; -- 2.11.0 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] leds: add LED_ON brightness as boolean value 2017-01-05 2:34 ` [PATCH v2] leds: add LED_ON brightness as boolean value Andi Shyti @ 2017-01-05 22:17 ` Jacek Anaszewski 0 siblings, 0 replies; 2+ messages in thread From: Jacek Anaszewski @ 2017-01-05 22:17 UTC (permalink / raw) To: Andi Shyti, Richard Purdie, Pavel Machek Cc: Jaechul Lee, linux-leds, linux-kernel, Andi Shyti Hi Andi, Thanks for the update. Applied. On 01/05/2017 03:34 AM, Andi Shyti wrote: > Some devices do not handle the led brightness or simply don't > care about it. Conceptually said devices want to just switch on > or off the led. It is useless in this case to have a 255 range > of brightness, while just having an LED_ON and LED_OFF improves > the boolean meaning of the led status. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > Acked-by: Pavel Machek <pavel@ucw.cz> > --- > Hi, > > Thanks Pavel and Jacek for your review. > > Differences from V1 > - used explicit assignement of LED_ON in the enum > - added Pavel's ack > > Andi > > include/linux/leds.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/leds.h b/include/linux/leds.h > index 569cb531094c..bb50d0151e75 100644 > --- a/include/linux/leds.h > +++ b/include/linux/leds.h > @@ -27,6 +27,7 @@ struct device; > > enum led_brightness { > LED_OFF = 0, > + LED_ON = 1, > LED_HALF = 127, > LED_FULL = 255, > }; > -- Best regards, Jacek Anaszewski ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-05 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170105023420epcas1p28624575ab6619e1930ebc05795725d90@epcas1p2.samsung.com>
2017-01-05 2:34 ` [PATCH v2] leds: add LED_ON brightness as boolean value Andi Shyti
2017-01-05 22:17 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®