From: Alexander Koch <mail@alexanderkoch.net>
To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Michael Hornung <mhornung.linux@gmail.com>,
devicetree@vger.kernel.org,
Alexander Koch <mail@alexanderkoch.net>
Subject: [PATCH v3 0/4] hwmon: adc128d818: Support missing operation modes
Date: Fri, 6 Jan 2017 11:38:13 +0100 [thread overview]
Message-ID: <20170106103817.11588-1-mail@alexanderkoch.net> (raw)
The ADC128D818 offers four different chip operation modes which vary in the
number and measurement types of the available input signals (see datasheet
sec. 8.4.1).
The current version of the driver only supports the default chip operation
mode (mode 0), providing seven analog values and a temperature reading.
This patch series adds support for operation modes 1-3, selectable through
the device tree attribute 'ti,mode':
adc1: adc128d818@1d {
compatible = "ti,adc128d818";
reg = <0x1d>;
mode = <1>;
};
The changes are transparent as the driver defaults to keeping the currently
active operation mode if no mode is specified via device tree (which is
mode 0 on chip initialization).
Changes from v2:
- Omit device attribute refactoring (for checkpatch.pl), as requested by
maintainer
- Add vendor prefix 'ti,' for mode property in device tree
- Drop size indication for mode property in device tree
- Preserve chip operation mode if none specified in devicetree
- Fix missing '\n' in dev_err() calls
Changes from v1:
- Add bindings document as first patch
- Preserve logical atomicity of code changes
- Improve sysfs device node handling (use is_visible() instead of
duplicate attribute list)
- Add trivial code refactoring stage for checkpatch.pl to succeed
Alexander Koch (4):
devicetree: hwmon: Add bindings for ADC128D818
hwmon: adc128d818: Implement mode selection via dt
hwmon: adc128d818: Support operation modes 1-3
hwmon: adc128d818: Preserve operation mode
.../devicetree/bindings/hwmon/adc128d818.txt | 39 ++++++
drivers/hwmon/adc128d818.c | 147 +++++++++++++++------
2 files changed, 149 insertions(+), 37 deletions(-)
create mode 100644 Documentation/devicetree/bindings/hwmon/adc128d818.txt
--
2.11.0
next reply other threads:[~2017-01-06 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 10:38 Alexander Koch [this message]
2017-01-06 10:38 ` [PATCH v3 1/4] devicetree: hwmon: Add bindings for ADC128D818 Alexander Koch
2017-01-10 5:35 ` Rob Herring
2017-01-06 10:38 ` [PATCH v3 2/4] hwmon: adc128d818: Implement mode selection via dt Alexander Koch
2017-01-06 10:38 ` [PATCH v3 3/4] hwmon: adc128d818: Support operation modes 1-3 Alexander Koch
2017-01-06 10:38 ` [PATCH v3 4/4] hwmon: adc128d818: Preserve operation mode Alexander Koch
2017-01-10 17:17 ` [PATCH v3 0/4] hwmon: adc128d818: Support missing operation modes Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106103817.11588-1-mail@alexanderkoch.net \
--to=mail@alexanderkoch.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mhornung.linux@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®