From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Christophe Ricard <christophe.ricard@gmail.com>
Subject: Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203
Date: Thu, 12 Jan 2017 13:19:02 -0700 [thread overview]
Message-ID: <20170112201902.GA15687@obsidianresearch.com> (raw)
In-Reply-To: <259e1606-255b-5bf4-54bb-1bed967c228a@maciej.szmigiero.name>
On Thu, Jan 12, 2017 at 09:09:33PM +0100, Maciej S. Szmigiero wrote:
> Hmm, I dug in history of tpm-interface.c and the code had actually rejected
> zero timeouts until commit 8e54caf407b98e (this is the commit that
> introduced the Atmel 3204 workaround) and let default timeout values remain
> instead (it looks like they were exactly like these in above override at
> that time).
The model changed around then.. Just printing if the timeout is 0 is
enough for now..
> Did Atmel 3204 report wrong but non-zero timeouts?
Yes, I think it may have..
Jason
next prev parent reply other threads:[~2017-01-12 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 18:08 Maciej S. Szmigiero
2017-01-12 18:42 ` Jason Gunthorpe
2017-01-12 20:09 ` Maciej S. Szmigiero
2017-01-12 20:19 ` Jason Gunthorpe [this message]
2017-01-12 20:20 ` Jarkko Sakkinen
2017-01-12 21:37 ` Maciej S. Szmigiero
2017-01-13 15:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112201902.GA15687@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=christophe.ricard@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®