mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kartikey Singh <dr.kartikeynrc@gmail.com>
Cc: insafonov@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: Fix semicolon after macro definition
Date: Sat, 14 Jan 2017 19:39:00 +0100	[thread overview]
Message-ID: <20170114183900.GB27644@kroah.com> (raw)
In-Reply-To: <20170114181756.mhnb3jmsscamsnhs@kartikey-HP-Notebook>

On Sat, Jan 14, 2017 at 11:47:56PM +0530, Kartikey Singh wrote:
> fixed a trailing semicolon after macro definition
> 
> Signed-off-by: Kartikey Singh <dr.kartikeynrc@gmail.com>
> ---
>  drivers/staging/rtl8188eu/include/basic_types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/basic_types.h b/drivers/staging/rtl8188eu/include/basic_types.h
> index 69c4d49..cbd6f92 100644
> --- a/drivers/staging/rtl8188eu/include/basic_types.h
> +++ b/drivers/staging/rtl8188eu/include/basic_types.h
> @@ -128,7 +128,7 @@ value to host byte ordering.*/
>  		(						\
>  		LE_BITS_CLEARED_TO_2BYTE(__pstart, __bitoffset, __bitlen) | \
>  		((((u16)__val) & BIT_LEN_MASK_16(__bitlen)) << (__bitoffset)) \
> -		);
> +		)

This macro, and others in this file, are also never used, can you just
remove them too?

thanks,

greg k-h

      reply	other threads:[~2017-01-14 18:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-14 18:17 Kartikey Singh
2017-01-14 18:39 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170114183900.GB27644@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dr.kartikeynrc@gmail.com \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®