From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bin Liu <b-liu@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/4] phy: sun4i-usb: support PHY0 on H3 in MUSB mode
Date: Tue, 17 Jan 2017 09:06:11 +0100 [thread overview]
Message-ID: <20170117080611.tn7s7ddj2csqr27m@lukather> (raw)
In-Reply-To: <20170116191449.50397-2-icenowy@aosc.xyz>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Tue, Jan 17, 2017 at 03:14:46AM +0800, Icenowy Zheng wrote:
> The PHY0 on H3 can be wired either to MUSB controller or OHCI/EHCI
> controller.
>
> The original driver wired it to OHCI/EHCI controller; however, as the
> code to use PHY0 as OHCI/EHCI is missing, it makes the PHY fully
> unusable.
>
> Rename the register (according to its function and the name in BSP
> driver), and remove the code which wires the PHY0 to OHCI/EHCI, as MUSB
> can support both peripheral and host mode (although the host mode of
> MUSB is buggy).
Can you elaborate on that? What's wrong with it?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-01-17 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170116191449.50397-1-icenowy@aosc.xyz>
[not found] ` <20170116191449.50397-2-icenowy@aosc.xyz>
2017-01-16 22:57 ` [linux-sunxi] " Ondřej Jirman
2017-01-17 8:06 ` Maxime Ripard [this message]
[not found] ` <3866431484672228@web20j.yandex.ru>
2017-01-17 20:06 ` Maxime Ripard
2017-01-17 20:09 ` Chen-Yu Tsai
2017-01-19 14:34 ` Maxime Ripard
[not found] ` <1682741484838608@web2j.yandex.ru>
2017-01-19 20:27 ` [linux-sunxi] " Karsten Merker
2017-01-20 8:04 ` Hans de Goede
[not found] ` <9112691485077945@web29h.yandex.ru>
2017-01-22 9:58 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117080611.tn7s7ddj2csqr27m@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=b-liu@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=icenowy@aosc.xyz \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®