* Re: [linux-sunxi] Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU
[not found] <20170117200213.27eGY8hi@smtp3h.mail.yandex.net>
@ 2017-01-19 15:41 ` Maxime Ripard
0 siblings, 0 replies; only message in thread
From: Maxime Ripard @ 2017-01-19 15:41 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Rob Herring, linux-clk, linux-kernel, devicetree, Zepan,
linux-doc, Jonathan Corbet, linux-arm-kernel, linux-sunxi,
Chen-Yu Tsai
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Wed, Jan 18, 2017 at 01:02:03AM +0800, Icenowy Zheng wrote:
>
> 2017年1月17日 17:04于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
> >
> > Hi,
> >
> > On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote:
> > > V3s has a similar but cut-down CCU to H3.
> > >
> > > Add support for it.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> > > ---
> >
> > Output from checkpatch:
> > total: 5 errors, 2 warnings, 3 checks, 857 lines checked
> >
> > > I think I should make a comparsion between V3s and H3 CCU here:
> > > (I won't mention the missing/added clocks here, only list conflicting clocks)
> >
> > That should be in your commit log.
>
> I think it can be easily get by a diff command :-)
>
> And we do not have the tradition to describe clock difference in
> commit log, is it right?
In very low details, no, but still having the big picture is a good
idea.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] only message in thread