mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] EDAC: always return an initialized value in knl_show_interleave_mode
Date: Sun, 22 Jan 2017 17:10:23 +0100	[thread overview]
Message-ID: <20170122161023.hmxbgiwse3f2qne6@pd.tnic> (raw)
In-Reply-To: <a3b9180e-2239-54db-6fb1-47577b994359@m4x.org>

On Sun, Jan 22, 2017 at 04:50:31PM +0100, Nicolas Iooss wrote:
>  	if (!is_knl)
>  		return interleave_mode(reg) ?
> 			"[8:6]" : "[8:6]XOR[18:16]";
>  	else
>  		return knl_intlv_mode[knl_interleave_mode(reg)];
> 
> Would this be good for you?

Ah, yes we interleave on address bits [8:6] when the bitield is 0 on KNL
while bitfield 0 for the rest of the families gives interleave mode for
the XOR of bits [8:6] and [18:16]. Good catch.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

      reply	other threads:[~2017-01-22 16:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22 13:51 Nicolas Iooss
2017-01-22 14:41 ` Borislav Petkov
2017-01-22 15:50   ` Nicolas Iooss
2017-01-22 16:10     ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170122161023.hmxbgiwse3f2qne6@pd.tnic \
    --to=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.iooss_linux@m4x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®