From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: xlpang@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org,
kexec@lists.infradead.org, Ingo Molnar <mingo@redhat.com>,
Dave Young <dyoung@redhat.com>,
Prarit Bhargava <prarit@redhat.com>,
Junichi Nomura <j-nomura@ce.jp.nec.com>,
Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: [PATCH] x86/mce: Keep quiet in case of broadcasted mce after system panic
Date: Mon, 23 Jan 2017 10:01:53 -0800 [thread overview]
Message-ID: <20170123180153.GA5646@intel.com> (raw)
In-Reply-To: <20170123175130.l7c7mnmu74ln5v6h@pd.tnic>
On Mon, Jan 23, 2017 at 06:51:30PM +0100, Borislav Petkov wrote:
> Hey Tony,
>
> a "welcome back" is in order? :-)
Yes - first day back today. Lots of catching up to do.
> And apparently crash knows about poisoned pages and handles them:
>
> static int __init crash_save_vmcoreinfo_init(void)
> {
> ...
> #ifdef CONFIG_MEMORY_FAILURE
> VMCOREINFO_NUMBER(PG_hwpoison);
> #endif
>
> so if that works, the kexeced kernel should know about that list.
Oh good ... it is smarter than I thought.
> Doesn't matter, right? The new copy is as clueless as the old one about
> those MCEs.
If things are well enough initialized that we don't reset, and
get to do_machine_check(), then this code from Ashok:
/* If this CPU is offline, just bail out. */
if (cpu_is_offline(smp_processor_id())) {
u64 mcgstatus;
mcgstatus = mce_rdmsrl(MSR_IA32_MCG_STATUS);
if (mcgstatus & MCG_STATUS_RIPV) {
mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
return;
}
}
will ignore the machine check on the other cpus ... assuming
that "cpu_is_offline(smp_processor_id())" does the right thing
in the kexec case where this is an "old" cpu that isn't online
in the new kernel.
-Tony
next prev parent reply other threads:[~2017-01-23 18:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 8:01 Xunlei Pang
2017-01-23 12:51 ` Borislav Petkov
2017-01-23 13:35 ` Xunlei Pang
2017-01-23 14:50 ` Borislav Petkov
2017-01-23 17:40 ` Luck, Tony
2017-01-23 17:51 ` Borislav Petkov
2017-01-23 18:01 ` Luck, Tony [this message]
2017-01-23 18:14 ` Borislav Petkov
2017-01-24 2:33 ` Xunlei Pang
2017-01-24 1:46 ` Xunlei Pang
2017-01-24 1:51 ` Xunlei Pang
2017-01-24 1:27 ` Xunlei Pang
2017-01-24 12:22 ` Borislav Petkov
2017-01-26 6:30 ` Xunlei Pang
2017-01-26 6:44 ` Borislav Petkov
2017-02-16 5:36 ` Xunlei Pang
2017-02-16 10:18 ` Borislav Petkov
2017-02-16 11:52 ` Xunlei Pang
2017-02-16 12:22 ` Borislav Petkov
2017-02-17 1:53 ` Xunlei Pang
2017-02-17 9:07 ` Borislav Petkov
2017-02-17 16:21 ` Xunlei Pang
2017-02-21 18:20 ` Luck, Tony
2017-02-22 5:50 ` Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123180153.GA5646@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=prarit@redhat.com \
--cc=x86@kernel.org \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome