From: Daniel Vetter <daniel@ffwll.ch>
To: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
LKML <linux-kernel@vger.kernel.org>,
DRI devel <dri-devel@lists.freedesktop.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation/gpu: drm-mm.rst: fix formatting for struct vm_operations_struct
Date: Tue, 31 Jan 2017 21:11:20 +0100 [thread overview]
Message-ID: <20170131201120.6vd22b6v5dfibo7x@phenom.ffwll.local> (raw)
In-Reply-To: <20170131174109.13690-1-Liviu.Dudau@arm.com>
On Tue, Jan 31, 2017 at 05:41:09PM +0000, Liviu Dudau wrote:
> drm-mm.rst contains some unformatted dump of the vm_operations_struct
> structure. Add some C formatting around it and some context for the
> dump. While there, update the structure to resemble the new signature
> for the fault handler after commit 25d3db7600b8 (mm, fs: reduce fault,
> page_mkwrite, and pfn_mkwrite to take only vmf).
>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Applied, thanks.
-Daniel
> ---
> Documentation/gpu/drm-mm.rst | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
> index 91d82f39fbf4..a1c0ae3b2c38 100644
> --- a/Documentation/gpu/drm-mm.rst
> +++ b/Documentation/gpu/drm-mm.rst
> @@ -291,10 +291,17 @@ To use :c:func:`drm_gem_mmap()`, drivers must fill the struct
> :c:type:`struct drm_driver <drm_driver>` gem_vm_ops field
> with a pointer to VM operations.
>
> -struct vm_operations_struct \*gem_vm_ops struct
> -vm_operations_struct { void (\*open)(struct vm_area_struct \* area);
> -void (\*close)(struct vm_area_struct \* area); int (\*fault)(struct
> -vm_area_struct \*vma, struct vm_fault \*vmf); };
> +The VM operations is a :c:type:`struct vm_operations_struct <vm_operations_struct>`
> +made up of several fields, the more interesting ones being:
> +
> +.. code-block:: c
> +
> + struct vm_operations_struct {
> + void (*open)(struct vm_area_struct * area);
> + void (*close)(struct vm_area_struct * area);
> + int (*fault)(struct vm_fault *vmf);
> + };
> +
>
> The open and close operations must update the GEM object reference
> count. Drivers can use the :c:func:`drm_gem_vm_open()` and
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2017-01-31 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 17:41 Liviu Dudau
2017-01-31 20:11 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131201120.6vd22b6v5dfibo7x@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=corbet@lwn.net \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®