From: Andrew Morton <akpm@linux-foundation.org>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, <linux-kernel@vger.kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
Tero Kristo <t-kristo@ti.com>, Sekhar Nori <nsekhar@ti.com>,
Nishanth Menon <nm@ti.com>,
Muralidharan Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH v3] initramfs: finish fput() before accessing any binary from initramfs
Date: Wed, 1 Feb 2017 14:12:13 -0800 [thread overview]
Message-ID: <20170201141213.3cf81a7a3a771ac2b94e8d48@linux-foundation.org> (raw)
In-Reply-To: <20170201140540.22051-1-lokeshvutla@ti.com>
On Wed, 1 Feb 2017 19:35:40 +0530 Lokesh Vutla <lokeshvutla@ti.com> wrote:
> commit 4a9d4b024a31 ("switch fput to task_work_add") implements a
> schedule_work() for completing fput(), but did not guarantee calling
> __fput() after unpacking initramfs. Because of this, there is a
> possibility that during boot a driver can see ETXTBSY when it tries
> to load a binary from initramfs as fput() is still pending on that
> binary. This patch makes sure that fput() is completed after unpacking
> initramfs and removes the call to flush_delayed_fput() in kernel_init()
> which happens very late after unpacking initramfs.
There's not really enough info here for others to be able to decide
which kernel versions need the fix. How serious is the bug? Given
that it's been there for 4 years, I assume "not very"?
next prev parent reply other threads:[~2017-02-01 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 14:05 Lokesh Vutla
2017-02-01 22:12 ` Andrew Morton [this message]
2017-02-03 17:19 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201141213.3cf81a7a3a771ac2b94e8d48@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=m-karicheri2@ti.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®