From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Rob Herring <robh@kernel.org>,
Stephen Boyd <stephen.boyd@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] phy: qcom-usb-hs: add extcon dependency
Date: Wed, 1 Feb 2017 17:08:55 +0100 [thread overview]
Message-ID: <20170201160917.1984877-1-arnd@arndb.de> (raw)
If extcon is a loadable module and qcom-usb-hs is built-in,
we get a link failure:
drivers/phy/phy-qcom-usb-hs.o: In function `qcom_usb_hs_phy_power_off':
phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_power_off+0x24): undefined reference to `extcon_unregister_notifier'
drivers/phy/phy-qcom-usb-hs.o: In function `qcom_usb_hs_phy_power_on':
phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_power_on+0x1a0): undefined reference to `extcon_get_state'
phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_power_on+0x1cc): undefined reference to `extcon_register_notifier'
drivers/phy/phy-qcom-usb-hs.o: In function `qcom_usb_hs_phy_probe':
phy-qcom-usb-hs.c:(.text.qcom_usb_hs_phy_probe+0x15c): undefined reference to `extcon_get_edev_by_phandle'
Adding a hard dependency avoids the problem. Alternatively we could
use "depends on EXTCON || !EXTCON" to allow building with extcon
disabled completely, but the other PHY drivers with extcon support
also just have a dependency, so this is more consistent.
Fixes: e2427b09ba92 ("phy: Add support for Qualcomm's USB HS phy")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 75907ecbef09..87c581f11297 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -443,6 +443,7 @@ config PHY_QCOM_UFS
config PHY_QCOM_USB_HS
tristate "Qualcomm USB HS PHY module"
+ depends on EXTCON
depends on USB_ULPI_BUS
select GENERIC_PHY
help
--
2.9.0
next reply other threads:[~2017-02-01 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 16:08 Arnd Bergmann [this message]
2017-02-01 18:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201160917.1984877-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=felipe.balbi@linux.intel.com \
--cc=groeck@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®