From: Thierry Reding <thierry.reding@gmail.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: seanpaul@chromium.org, marcheu@chromium.org,
briannorris@chromium.org, hoegsberg@google.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: simple: ensure Sharp lq123p1jx31 isn't turned off too soon
Date: Mon, 6 Feb 2017 13:03:14 +0100 [thread overview]
Message-ID: <20170206120314.GK27607@ulmo.ba.sec> (raw)
In-Reply-To: <20170202233853.13818-1-dianders@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
On Thu, Feb 02, 2017 at 03:38:53PM -0800, Douglas Anderson wrote:
> The Sharp lq123p1jx31 has a requirement that the VDD is on for at
> least 300 ms before being turned off. At the moment nothing anywhere
> in the kernel is ensuring this.
Looks to me like .delay.prepare would be a better fit. That enables the
regulator and setting it to 300 ms would make sure that the regulator
will always get enabled for at least 300 ms.
Anyway, your commit message says nothing about why this is important.
What are the side-effects if the above isn't true? Does the display hang
in some way?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-02-06 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 23:38 Douglas Anderson
2017-02-04 2:36 ` Doug Anderson
2017-02-06 12:03 ` Thierry Reding [this message]
2017-02-06 16:15 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206120314.GK27607@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegsberg@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcheu@chromium.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®