mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sainath.grandhi@intel.com
Cc: netdev@vger.kernel.org, mahesh@bandewar.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces
Date: Tue, 07 Feb 2017 13:28:22 -0500 (EST)	[thread overview]
Message-ID: <20170207.132822.668043461053676694.davem@davemloft.net> (raw)
In-Reply-To: <1486416975-14133-1-git-send-email-sainath.grandhi@intel.com>

From: Sainath Grandhi <sainath.grandhi@intel.com>
Date: Mon,  6 Feb 2017 13:36:08 -0800

> Tap character devices can be implemented on other virtual interfaces like
> ipvlan, similar to macvtap. Source code for tap functionality in macvtap
> can be re-used for this purpose.
> 
> This patch series splits macvtap source into two modules, macvtap and tap.
> This patch series also includes a patch for implementing tap character
> device driver based on the IP-VLAN network interface, called ipvtap.
> 
> These patches are tested on x86 platform.

You're going to have to rework the module and Kconfig parts of this set
of changes.

The user should not have to modify any existing Kconfig setting to get
the same set of modules which already exist today.

Yet when I run "make oldconfig" after applying these changes it prompts
me for:

    TAP module support for virtual interfaces (TAP) [N/m/y/?] (NEW) 

And that's not really acceptable.  I had MACVTAP set, I should still get
the infrastructure necessary to get that module built.

If you want to do patch #6 you have to do it in a way that is transparent
to existing kernel configs.

Thanks.

  parent reply	other threads:[~2017-02-07 18:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 21:36 Sainath Grandhi
2017-02-06 21:36 ` [PATCHv4 1/7] tap: Refactoring macvtap.c Sainath Grandhi
2017-02-06 21:36 ` [PATCHv4 2/7] tap: Renaming tap related APIs, data structures, macros Sainath Grandhi
2017-02-06 21:36 ` [PATCHv4 3/7] tap: Tap character device creation/destroy API Sainath Grandhi
2017-02-06 21:36 ` [PATCHv4 4/7] tap: Abstract type of virtual interface from tap implementation Sainath Grandhi
2017-02-06 21:36 ` [PATCHv4 5/7] tap: Extending tap device create/destroy APIs Sainath Grandhi
2017-02-06 21:36 ` [PATCHv4 6/7] tap: tap as an independent module Sainath Grandhi
2017-02-06 21:36 ` [PATCHv4 7/7] ipvtap: IP-VLAN based tap driver Sainath Grandhi
2017-02-07 18:28 ` David Miller [this message]
2017-02-08 21:41   ` [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces Grandhi, Sainath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207.132822.668043461053676694.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahesh@bandewar.net \
    --cc=netdev@vger.kernel.org \
    --cc=sainath.grandhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®