From: Peter Zijlstra <peterz@infradead.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Kees Cook <keescook@chromium.org>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
"H. Peter Anvin" <h.peter.anvin@intel.com>,
Will Deacon <will.deacon@arm.com>,
David Windsor <dwindsor@gmail.com>,
Hans Liljestrand <ishkamiel@gmail.com>,
David Howells <dhowells@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [kernel-hardening] Re: [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION
Date: Tue, 7 Feb 2017 18:30:36 +0100 [thread overview]
Message-ID: <20170207173036.GS6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20170207160300.GB26173@leverpostej>
On Tue, Feb 07, 2017 at 04:03:01PM +0000, Mark Rutland wrote:
> For x86 it's a little painful due to '%' in the register names, but it looks
> possible. The below appears to do the mangling correctly (then screams due to
> the mangled result being nonexistent).
> asm(
> " .macro reg_to_offset r\n"
> " .irp rs,eax,ebx,ecx,edx\n"
> " .ifc \\r, %\\rs\n"
> " __offset_of_\\rs\n"
> " .endif\n"
> " .endr\n"
> " .endm\n"
> );
>
> #define asm_sym(var) asm volatile("reg_to_offset %0\n" : : "r" (var))
Oh gawd that's a most gnarly hack.
Do we want to go do that for all archs or somehow cook a generic
fallback that ends up doing a full function call or something?
next prev parent reply other threads:[~2017-02-07 17:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 23:26 [PATCH 0/4] refcount_t followups Kees Cook
2017-02-03 23:26 ` [PATCH 1/4] refcount_t: fix Kconfig help Kees Cook
2017-02-03 23:26 ` [PATCH 2/4] lkdtm: convert to refcount_t testing Kees Cook
2017-02-10 8:32 ` [tip:locking/core] lkdtm: Convert " tip-bot for Kees Cook
2017-02-03 23:26 ` [PATCH 3/4] bug: Switch data corruption check to __must_check Kees Cook
2017-02-03 23:26 ` [PATCH 4/4] refcount: Report failures through CHECK_DATA_CORRUPTION Kees Cook
2017-02-05 15:40 ` Peter Zijlstra
2017-02-05 23:33 ` Kees Cook
2017-02-06 8:57 ` Peter Zijlstra
2017-02-06 16:54 ` Kees Cook
2017-02-07 8:34 ` Peter Zijlstra
2017-02-07 11:10 ` [kernel-hardening] " Mark Rutland
2017-02-07 12:36 ` Peter Zijlstra
2017-02-07 13:50 ` Mark Rutland
2017-02-07 15:07 ` Peter Zijlstra
2017-02-07 16:03 ` Mark Rutland
2017-02-07 17:30 ` Peter Zijlstra [this message]
2017-02-07 17:55 ` Mark Rutland
2017-02-08 9:12 ` Peter Zijlstra
2017-02-08 9:43 ` Peter Zijlstra
2017-02-08 14:10 ` Mark Rutland
2017-02-08 21:20 ` Kees Cook
2017-02-09 10:27 ` Peter Zijlstra
2017-02-10 23:39 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207173036.GS6515@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=dwindsor@gmail.com \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=h.peter.anvin@intel.com \
--cc=ishkamiel@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome