From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Mark Brown <broonie@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>
Subject: Re: [PATCH] spi: s3c64xx: fix inconsistency between binding and driver
Date: Tue, 7 Feb 2017 22:33:36 +0200 [thread overview]
Message-ID: <20170207203336.3oetygxh4eofqlml@kozik-lap> (raw)
In-Reply-To: <20170207080748.9524-1-andi.shyti@samsung.com>
On Tue, Feb 07, 2017 at 05:07:48PM +0900, Andi Shyti wrote:
> Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS
> line is not connected") introduced an inconsistency between the
> binding where the disconnected CS line was marked as
> 'no-cs-readback' while the driver was erroneously checking for
> 'broken-cs'.
Please describe in one sentence the visible output of this error to
justify backporting and then:
Fixes: a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected")
Cc: <stable@vger.kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-02-07 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170207080820epcas5p3a680e8126abf88d53106b23c3aab9958@epcas5p3.samsung.com>
2017-02-07 8:07 ` Andi Shyti
2017-02-07 20:33 ` Krzysztof Kozlowski [this message]
2017-02-13 18:54 ` Applied "spi: s3c64xx: fix inconsistency between binding and driver" to the spi tree Mark Brown
2017-02-14 5:49 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207203336.3oetygxh4eofqlml@kozik-lap \
--to=krzk@kernel.org \
--cc=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®