From: Lee Jones <lee.jones@linaro.org>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()
Date: Wed, 8 Feb 2017 12:02:22 +0000 [thread overview]
Message-ID: <20170208120222.pyhxy2c4yfzy32sj@dell> (raw)
In-Reply-To: <20170202205935.1452-1-bp@alien8.de>
On Thu, 02 Feb 2017, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> It is a debugging statement so make it be issued only then.
>
> No functionality change.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/rtsx_pcr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index 98029ee0959e..850590aac008 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -927,7 +927,7 @@ static irqreturn_t rtsx_pci_isr(int irq, void *dev_id)
>
> static int rtsx_pci_acquire_irq(struct rtsx_pcr *pcr)
> {
> - dev_info(&(pcr->pci->dev), "%s: pcr->msi_en = %d, pci->irq = %d\n",
> + pcr_dbg(pcr, "%s: pcr->msi_en = %d, pci->irq = %d\n",
> __func__, pcr->msi_en, pcr->pci->irq);
I usually disapprove of these kinds of abstractions.
What is the point of it?
Why can't you just use dev_dbg()?
> if (request_irq(pcr->pci->irq, rtsx_pci_isr,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-02-08 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 20:59 Borislav Petkov
2017-02-08 12:02 ` Lee Jones [this message]
2017-02-08 12:54 ` Borislav Petkov
2017-03-14 13:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208120222.pyhxy2c4yfzy32sj@dell \
--to=lee.jones@linaro.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®