From: Borislav Petkov <bp@alien8.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()
Date: Wed, 8 Feb 2017 13:54:24 +0100 [thread overview]
Message-ID: <20170208125424.jun6unesnxk45sd6@pd.tnic> (raw)
In-Reply-To: <20170208120222.pyhxy2c4yfzy32sj@dell>
On Wed, Feb 08, 2017 at 12:02:22PM +0000, Lee Jones wrote:
> I usually disapprove of these kinds of abstractions.
>
> What is the point of it?
>
> Why can't you just use dev_dbg()?
I was simply following what the rest of the driver does. It has 20
pcr_dbg() calls and 5 dev_dbg().
If you want to address that, then a patch ontop should convert all
pcr_dbg() calls to dev_dbg().
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-02-08 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 20:59 Borislav Petkov
2017-02-08 12:02 ` Lee Jones
2017-02-08 12:54 ` Borislav Petkov [this message]
2017-03-14 13:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208125424.jun6unesnxk45sd6@pd.tnic \
--to=bp@alien8.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®