From: David Miller <davem@davemloft.net>
To: jon.mason@broadcom.com
Cc: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
zschroff@broadcom.com
Subject: Re: [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug
Date: Thu, 09 Feb 2017 17:04:22 -0500 (EST) [thread overview]
Message-ID: <20170209.170422.2219490608301068441.davem@davemloft.net> (raw)
In-Reply-To: <1486588377-7681-2-git-send-email-jon.mason@broadcom.com>
From: Jon Mason <jon.mason@broadcom.com>
Date: Wed, 8 Feb 2017 16:12:56 -0500
> The code now checks to see if the adapter needs to be brought out of
> reset (where as before it was doing an IDM write to bring it out of
> reset regardless of whether it was in reset or not). Also, removed
> unnecessary usleeps (as there is already a read present to flush the
> IDM writes).
That's not what the delays are there for, I don't think you can
safely remove them.
It's for waiting for the reset to complete after the write to
the register has propagated by the read back.
Please retain the delays.
Thanks.
next prev parent reply other threads:[~2017-02-09 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 21:12 [PATCH net v3 0/2] net: ethernet: bgmac: bug fixes Jon Mason
2017-02-08 21:12 ` [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug Jon Mason
2017-02-09 22:04 ` David Miller [this message]
2017-02-08 21:12 ` [PATCH net v3 2/2] net: ethernet: bgmac: mac address change bug Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209.170422.2219490608301068441.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=zschroff@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®