* [PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe()
@ 2017-02-09 15:30 Wei Yongjun
2017-02-09 16:45 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-02-09 15:30 UTC (permalink / raw)
To: Bartosz Golaszewski, Sekhar Nori, Rob Herring, Kevin Hilman
Cc: Wei Yongjun, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/bus/da8xx-mstpri.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
index 9af9bcc..5595af1 100644
--- a/drivers/bus/da8xx-mstpri.c
+++ b/drivers/bus/da8xx-mstpri.c
@@ -218,10 +218,8 @@ static int da8xx_mstpri_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
mstpri = devm_ioremap_resource(dev, res);
- if (IS_ERR(mstpri)) {
- dev_err(dev, "unable to map MSTPRI registers\n");
+ if (IS_ERR(mstpri))
return PTR_ERR(mstpri);
- }
prio_list = da8xx_mstpri_get_board_prio();
if (!prio_list) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe()
2017-02-09 15:30 [PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe() Wei Yongjun
@ 2017-02-09 16:45 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2017-02-09 16:45 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Sekhar Nori, Rob Herring, Kevin Hilman, Wei Yongjun, LKML
2017-02-09 16:30 GMT+01:00 Wei Yongjun <weiyj.lk@gmail.com>:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bus/da8xx-mstpri.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index 9af9bcc..5595af1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -218,10 +218,8 @@ static int da8xx_mstpri_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> mstpri = devm_ioremap_resource(dev, res);
> - if (IS_ERR(mstpri)) {
> - dev_err(dev, "unable to map MSTPRI registers\n");
> + if (IS_ERR(mstpri))
> return PTR_ERR(mstpri);
> - }
>
> prio_list = da8xx_mstpri_get_board_prio();
> if (!prio_list) {
>
>
>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-09 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-09 15:30 [PATCH -next] bus: da850-mstpri: remove redundant dev_err call in da8xx_mstpri_probe() Wei Yongjun
2017-02-09 16:45 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®