From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: Abel Vesa <abelvesa@linux.com>,
Steven Rostedt <rostedt@goodmis.org>,
mingo@redhat.com, viro@zeniv.linux.org.uk,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.com>,
robin.murphy@arm.com, zhouchengming1@huawei.com
Subject: Re: [PATCHv3] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS
Date: Thu, 9 Feb 2017 15:49:13 +0000 [thread overview]
Message-ID: <20170209154913.GG27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CACh+v5Nrva=dyJzteomPCzaz01pBBuChesR-9Ft=jeAf0zZoxA@mail.gmail.com>
On Thu, Feb 09, 2017 at 04:38:32PM +0100, Jean-Jacques Hiblot wrote:
> 2017-02-07 23:57 GMT+01:00 Abel Vesa <abelvesa@linux.com>:
> > +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> > +.macro __ftrace_graph_regs_caller
> > +
> > + sub r0, fp, #4 @ lr of instrumented routine (parent)
> > +
> > + @ called from __ftrace_regs_caller
> > + ldr r1, [sp, #56] @ instrumented routine (func)
> > + mcount_adjust_addr r1, r1
> > +
> > + sub r2, r0, #4 @ frame pointer
> why not mov r2, fp ?
r0 = fp - 4
r2 = r0 - 4
therefore
r2 = (fp - 4) - 4
r2 = fp - 8, not r2 = fp
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-02-09 15:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 22:57 Abel Vesa
2017-02-09 15:38 ` Jean-Jacques Hiblot
2017-02-09 15:49 ` Russell King - ARM Linux [this message]
2017-02-09 16:29 ` Russell King - ARM Linux
2017-02-09 17:13 ` Steven Rostedt
2017-02-09 18:06 ` Russell King - ARM Linux
2017-02-09 18:14 ` Steven Rostedt
2017-02-09 18:14 ` Steven Rostedt
2017-02-09 19:01 ` Abel Vesa
2017-02-09 19:09 ` Abel Vesa
2017-02-09 18:18 ` Abel Vesa
2017-02-09 18:30 ` Abel Vesa
2017-02-10 10:36 ` Jean-Jacques Hiblot
2017-02-10 12:03 ` Abel Vesa
2017-02-10 13:57 ` Jean-Jacques Hiblot
2017-02-10 17:27 ` Abel Vesa
2017-02-10 14:28 ` Russell King - ARM Linux
2017-02-10 17:17 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209154913.GG27312@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=abelvesa@linux.com \
--cc=jjhiblot@traphandler.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®