From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] tpm: export tpm2_flush_context_cmd
Date: Fri, 10 Feb 2017 09:42:12 +0200 [thread overview]
Message-ID: <20170210074212.pi7xb4rvjuwfkdj7@intel.com> (raw)
In-Reply-To: <20170208175830.GA31571@obsidianresearch.com>
On Wed, Feb 08, 2017 at 10:58:30AM -0700, Jason Gunthorpe wrote:
> > /**
> > + * tpm2_flush_context_cmd() - execute a TPM2_FlushContext command
> > + * @chip: TPM chip to use
> > + * @payload: the key data in clear and encrypted form
> > + * @options: authentication values and other options
> > + *
> > + * Return: same as with tpm_transmit_cmd
> > + */
> > +void tpm2_flush_context_cmd(struct tpm_chip *chip, u32 handle,
> > + unsigned int flags)
>
> Why did you move the function in the same file? Adding a prototype
> shouldn't require that..
>
> Jason
To be logically positioned in the same way as it is in the header.
It cannot in-between the helper functions for tpm2_seal_trusted().
/Jarkko
next prev parent reply other threads:[~2017-02-10 7:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 11:07 [PATCH 0/6] in-kernel resource manager Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 1/6] tpm: validate TPM 2.0 commands Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 2/6] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen
2017-02-08 17:58 ` Jason Gunthorpe
2017-02-10 7:42 ` Jarkko Sakkinen [this message]
2017-02-08 11:07 ` [PATCH 3/6] tpm: infrastructure for TPM spaces Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 4/6] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 5/6] tpm: expose spaces via a device link /dev/tpms<n> Jarkko Sakkinen
2017-02-08 11:07 ` [PATCH 6/6] tpm2: add session handle context saving and restoring to the space code Jarkko Sakkinen
2017-02-10 8:52 ` Jarkko Sakkinen
2017-02-10 16:11 ` James Bottomley
2017-02-10 19:07 ` [PATCH 6/6] tpm2: add session handle context saving and restoring to the space code' Jarkko Sakkinen
2017-02-10 12:32 ` [PATCH 6/6] tpm2: add session handle context saving and restoring to the space code Jarkko Sakkinen
2017-02-10 16:17 ` James Bottomley
2017-02-10 19:10 ` Jarkko Sakkinen
2017-02-10 19:12 ` [tpmdd-devel] " James Bottomley
2017-02-10 22:48 ` Jarkko Sakkinen
2017-02-10 8:53 ` [PATCH 0/6] in-kernel resource manager Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210074212.pi7xb4rvjuwfkdj7@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®