* [PATCH] kernel: tracing: use modern function declaration
@ 2017-01-23 12:24 Arnd Bergmann
2017-02-14 20:12 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-01-23 12:24 UTC (permalink / raw)
To: Steven Rostedt
Cc: Arnd Bergmann, Ingo Molnar, Namhyung Kim, Tom Zanussi,
Masami Hiramatsu, linux-kernel
We get a lot of harmless warnings about this header file at W=1 level
because of an unusual function declaration:
kernel/trace/trace.h:766:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
This moves the inline statement where it normally belongs, avoiding the
warning.
Fixes: 4046bf023b06 ("ftrace: Expose ftrace_hash_empty and ftrace_lookup_ip")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/trace/trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index afbec961eab1..6806932f6bd9 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -763,7 +763,7 @@ struct ftrace_hash {
struct ftrace_func_entry *
ftrace_lookup_ip(struct ftrace_hash *hash, unsigned long ip);
-static bool __always_inline ftrace_hash_empty(struct ftrace_hash *hash)
+static __always_inline bool ftrace_hash_empty(struct ftrace_hash *hash)
{
return !hash || !hash->count;
}
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel: tracing: use modern function declaration
2017-01-23 12:24 [PATCH] kernel: tracing: use modern function declaration Arnd Bergmann
@ 2017-02-14 20:12 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2017-02-14 20:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ingo Molnar, Namhyung Kim, Tom Zanussi, Masami Hiramatsu, linux-kernel
On Mon, 23 Jan 2017 13:24:45 +0100
Arnd Bergmann <arnd@arndb.de> wrote:
> We get a lot of harmless warnings about this header file at W=1 level
> because of an unusual function declaration:
>
> kernel/trace/trace.h:766:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration]
>
> This moves the inline statement where it normally belongs, avoiding the
> warning.
>
> Fixes: 4046bf023b06 ("ftrace: Expose ftrace_hash_empty and ftrace_lookup_ip")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, Thanks!
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 20:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23 12:24 [PATCH] kernel: tracing: use modern function declaration Arnd Bergmann
2017-02-14 20:12 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®