From: Greg KH <gregkh@linuxfoundation.org>
To: Weiwei Jia <harrynjit@gmail.com>
Cc: bsingharora@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC] blkio_delay_total is calculated mistakenly
Date: Tue, 14 Feb 2017 19:00:13 -0800 [thread overview]
Message-ID: <20170215030013.GA22460@kroah.com> (raw)
In-Reply-To: <CA+scX6mv2ZZD=1vm=BeKrxPY-NvU_r6QSa+KcsMmJn=j66KJmQ@mail.gmail.com>
On Tue, Feb 14, 2017 at 08:27:36PM -0500, Weiwei Jia wrote:
> Hi,
>
> When I read Linux Kernel source codes about how "blkio_delay_total"
> (delay waiting for synchronous block I/O to complete for one task) is
> calculated in Linux/kernel/delayacct.c file [1], I find that
> "blkio_delay_total" adds "task->delays->blkio_delay" to be the total
> delay time for one task to wait for synchronous I/O dynamically but
> "tsk->delays->blkio_delay" has already been calculated as the total
> delay time that one task is waiting for synchronous I/O [2]
> dynamically. I think "blkio_delay_total" should not add
> "task->delays->blkio_delay" since "task->delays->blkio_delay" is
> already the total delay time we want.
>
> Am I missing anything?
Why are you sending this to me? You have read
Documentation/SubmittingPatches, right?
Please use scripts/get_maintainers.pl for who to send patches to.
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-15 3:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 1:27 Weiwei Jia
2017-02-15 3:00 ` Greg KH [this message]
2017-02-15 3:12 ` Weiwei Jia
2017-03-02 13:51 ` Weiwei Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215030013.GA22460@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bsingharora@gmail.com \
--cc=harrynjit@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®