From: Eddie Kovsky <ewk@edkovsky.org>
To: jeyu@redhat.com, rusty@rustcorp.com.au, keescook@chromium.org,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com
Cc: linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com
Subject: [PATCH v2 3/3] Make vmbus register arguments read-only
Date: Fri, 17 Feb 2017 22:58:44 -0700 [thread overview]
Message-ID: <20170218055844.1457-4-ewk@edkovsky.org> (raw)
In-Reply-To: <20170218055844.1457-1-ewk@edkovsky.org>
Use the new RO check functions introduced in this series to make the
vmbus register functions verify that the address of their arguments are
read-only. Addresses that fail the verification are rejected.
Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
---
drivers/hv/vmbus_drv.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index c1b27026f744..e527454ffa59 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1026,6 +1026,11 @@ int __vmbus_driver_register(struct hv_driver *hv_driver, struct module *owner, c
if (ret < 0)
return ret;
+ ret = kernel_ro_address(&hv_driver);
+ if (ret < 1)
+ pr_err("Module address is not read-only.");
+ return ret;
+
hv_driver->driver.name = hv_driver->name;
hv_driver->driver.owner = owner;
hv_driver->driver.mod_name = mod_name;
@@ -1092,6 +1097,11 @@ int vmbus_device_register(struct hv_device *child_device_obj)
{
int ret = 0;
+ ret = kernel_ro_address(&child_device_obj);
+ if (ret < 1)
+ pr_err("Device address is not read-only.");
+ return ret;
+
dev_set_name(&child_device_obj->device, "%pUl",
child_device_obj->channel->offermsg.offer.if_instance.b);
--
2.11.1
next prev parent reply other threads:[~2017-02-18 6:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 5:58 [PATCH v2 0/3] provide check for ro_after_init memory sections Eddie Kovsky
2017-02-18 5:58 ` [PATCH v2 1/3] module: verify address is read-only Eddie Kovsky
2017-02-20 17:14 ` Stephen Hemminger
2017-02-21 20:32 ` Kees Cook
2017-02-21 20:51 ` Stephen Hemminger
2017-02-26 17:42 ` Jessica Yu
2017-02-18 5:58 ` [PATCH v2 2/3] extable: " Eddie Kovsky
2017-02-18 6:33 ` kbuild test robot
2017-02-18 6:49 ` kbuild test robot
2017-02-18 5:58 ` Eddie Kovsky [this message]
2017-02-18 6:30 ` [PATCH v2 3/3] Make vmbus register arguments read-only kbuild test robot
2017-02-18 8:55 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170218055844.1457-4-ewk@edkovsky.org \
--to=ewk@edkovsky.org \
--cc=haiyangz@microsoft.com \
--cc=jeyu@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®