mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Eddie Kovsky <ewk@edkovsky.org>
Cc: kbuild-all@01.org, jeyu@redhat.com, rusty@rustcorp.com.au,
	keescook@chromium.org, kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH v2 3/3] Make vmbus register arguments read-only
Date: Sat, 18 Feb 2017 14:30:17 +0800	[thread overview]
Message-ID: <201702181447.mUVrm6eg%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170218055844.1457-4-ewk@edkovsky.org>

[-- Attachment #1: Type: text/plain, Size: 2944 bytes --]

Hi Eddie,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.10-rc8 next-20170217]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Eddie-Kovsky/provide-check-for-ro_after_init-memory-sections/20170218-141040
config: i386-randconfig-x007-201707 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/hv/vmbus_drv.c: In function '__vmbus_driver_register':
>> drivers/hv/vmbus_drv.c:1056:26: warning: passing argument 1 of 'kernel_ro_address' makes integer from pointer without a cast [-Wint-conversion]
     ret = kernel_ro_address(&hv_driver);
                             ^
   In file included from include/linux/list.h:8:0,
                    from include/linux/module.h:9,
                    from drivers/hv/vmbus_drv.c:26:
   include/linux/kernel.h:446:12: note: expected 'long unsigned int' but argument is of type 'struct hv_driver **'
    extern int kernel_ro_address(unsigned long addr);
               ^~~~~~~~~~~~~~~~~
   drivers/hv/vmbus_drv.c: In function 'vmbus_device_register':
   drivers/hv/vmbus_drv.c:1127:26: warning: passing argument 1 of 'kernel_ro_address' makes integer from pointer without a cast [-Wint-conversion]
     ret = kernel_ro_address(&child_device_obj);
                             ^
   In file included from include/linux/list.h:8:0,
                    from include/linux/module.h:9,
                    from drivers/hv/vmbus_drv.c:26:
   include/linux/kernel.h:446:12: note: expected 'long unsigned int' but argument is of type 'struct hv_device **'
    extern int kernel_ro_address(unsigned long addr);
               ^~~~~~~~~~~~~~~~~

vim +/kernel_ro_address +1056 drivers/hv/vmbus_drv.c

  1040	 *
  1041	 * Registers the given driver with Linux through the 'driver_register()' call
  1042	 * and sets up the hyper-v vmbus handling for this driver.
  1043	 * It will return the state of the 'driver_register()' call.
  1044	 *
  1045	 */
  1046	int __vmbus_driver_register(struct hv_driver *hv_driver, struct module *owner, const char *mod_name)
  1047	{
  1048		int ret;
  1049	
  1050		pr_info("registering driver %s\n", hv_driver->name);
  1051	
  1052		ret = vmbus_exists();
  1053		if (ret < 0)
  1054			return ret;
  1055	
> 1056		ret = kernel_ro_address(&hv_driver);
  1057		if (ret < 1)
  1058			pr_err("Module address is not read-only.");
  1059			return ret;
  1060	
  1061		hv_driver->driver.name = hv_driver->name;
  1062		hv_driver->driver.owner = owner;
  1063		hv_driver->driver.mod_name = mod_name;
  1064		hv_driver->driver.bus = &hv_bus;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25048 bytes --]

  reply	other threads:[~2017-02-18  6:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18  5:58 [PATCH v2 0/3] provide check for ro_after_init memory sections Eddie Kovsky
2017-02-18  5:58 ` [PATCH v2 1/3] module: verify address is read-only Eddie Kovsky
2017-02-20 17:14   ` Stephen Hemminger
2017-02-21 20:32     ` Kees Cook
2017-02-21 20:51       ` Stephen Hemminger
2017-02-26 17:42   ` Jessica Yu
2017-02-18  5:58 ` [PATCH v2 2/3] extable: " Eddie Kovsky
2017-02-18  6:33   ` kbuild test robot
2017-02-18  6:49   ` kbuild test robot
2017-02-18  5:58 ` [PATCH v2 3/3] Make vmbus register arguments read-only Eddie Kovsky
2017-02-18  6:30   ` kbuild test robot [this message]
2017-02-18  8:55   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201702181447.mUVrm6eg%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=ewk@edkovsky.org \
    --cc=haiyangz@microsoft.com \
    --cc=jeyu@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®