mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: santosh.shilimkar@oracle.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next][PATCH] RDS: keep data type consistent in the user visible header
Date: Mon, 20 Feb 2017 10:19:51 -0500 (EST)	[thread overview]
Message-ID: <20170220.101951.663166903772216217.davem@davemloft.net> (raw)
In-Reply-To: <1487387747-5324-1-git-send-email-santosh.shilimkar@oracle.com>

From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Date: Fri, 17 Feb 2017 19:15:47 -0800

> From: Santosh Shilimkar <ssantosh@kernel.org>
> 
> rds.h is exported to /usr/include/rds.h,  so u8, u64 leads to
> errors like below.
> 
> /usr/include/linux/rds.h:197: error: expected specifier-qualifier-list before 'u8'
> /usr/include/linux/rds.h:202: error: expected specifier-qualifier-list before 'u8'
> 
> Fix it by following same types as rest of the user header.
> 
> Reported-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
> Signed-off-by: Santosh Shilimkar <ssantosh.shilimkar@oracle.org>

The correct fix it to use "__u8", "__u64", etc.

  reply	other threads:[~2017-02-20 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-18  3:15 Santosh Shilimkar
2017-02-20 15:19 ` David Miller [this message]
2017-02-20 15:37   ` Sowmini Varadhan
2017-02-20 15:39     ` David Miller
2017-02-21 14:29       ` David Laight
2017-02-21 14:55         ` santosh.shilimkar
2017-02-21 14:58         ` Edward Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170220.101951.663166903772216217.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=santosh.shilimkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®