mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: tip.today - scheduler bam boom crash (cpu hotplug)
Date: Mon, 27 Feb 2017 15:05:00 +0100	[thread overview]
Message-ID: <20170227140500.GX6500@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CANRm+Cy6yZtQcHx4K_S30RLjHgjze5JEFUBkziCVtUu9C4FfqQ@mail.gmail.com>

On Mon, Feb 27, 2017 at 09:48:35PM +0800, Wanpeng Li wrote:
> 2017-02-27 20:43 GMT+08:00 Peter Zijlstra <peterz@infradead.org>:
> > I have no clue what that tries to do.
> 
> The patch tries to mark sched clock stable if
> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT / PVCLOCK_TSC_STABLE_BIT is set in
> kvm guest even if there is no invariant tsc cpuid bit.

I just ripped out the interface to 'set stable' for good reasons. Also,
the branch you add it to doesn't in fact do clear_stable -- so who does?

Also, the sched/clock.c code shouldn't know about hypervisor anything.

So whatever it is you're doing, you're doing it wrong.

      reply	other threads:[~2017-02-27 14:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  7:31 Mike Galbraith
2017-01-19 10:19 ` Peter Zijlstra
2017-01-19 11:39   ` Mike Galbraith
2017-01-19 13:36   ` Peter Zijlstra
2017-01-19 16:54     ` Ingo Molnar
2017-01-19 17:20       ` Peter Zijlstra
2017-01-19 20:35     ` sched/clock: Fix hotplug issue kbuild test robot
2017-01-19 20:37     ` kbuild test robot
2017-01-20  6:36     ` [tip:sched/core] sched/clock: Fix hotplug crash tip-bot for Peter Zijlstra
2017-02-27 12:30     ` tip.today - scheduler bam boom crash (cpu hotplug) Wanpeng Li
2017-02-27 12:35       ` Paolo Bonzini
2017-02-27 12:43       ` Peter Zijlstra
2017-02-27 12:50         ` Paolo Bonzini
2017-02-27 13:04           ` Peter Zijlstra
2017-02-27 15:27             ` Paolo Bonzini
2017-02-27 15:59               ` Peter Zijlstra
2017-02-27 16:11                 ` Paolo Bonzini
2017-02-27 16:36                   ` Peter Zijlstra
2017-02-27 17:27                     ` Paolo Bonzini
2017-02-27 17:40                       ` Thomas Gleixner
2017-02-27 19:06                         ` Paolo Bonzini
2017-02-27 20:35                           ` Peter Zijlstra
2017-02-28  1:51                   ` Wanpeng Li
2017-02-28  8:08                     ` Peter Zijlstra
2017-02-28  8:11                       ` Wanpeng Li
2017-03-01 13:39                         ` Wanpeng Li
2017-03-01 14:17                           ` Peter Zijlstra
2017-02-27 13:48         ` Wanpeng Li
2017-02-27 14:05           ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227140500.GX6500@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=efault@gmx.de \
    --cc=kernellwp@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pbonzini@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome