From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>, Wanpeng Li <kernellwp@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>
Subject: Re: tip.today - scheduler bam boom crash (cpu hotplug)
Date: Mon, 27 Feb 2017 13:50:29 +0100 [thread overview]
Message-ID: <3e7c34e2-757b-19e9-f7e5-9bfaadd79e5d@redhat.com> (raw)
In-Reply-To: <20170227124349.GU6515@twins.programming.kicks-ass.net>
On 27/02/2017 13:43, Peter Zijlstra wrote:
> On Mon, Feb 27, 2017 at 08:30:11PM +0800, Wanpeng Li wrote:
>
>>> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
>>> index 2a5cafd..542710b 100644
>>> --- a/arch/x86/kernel/kvmclock.c
>>> +++ b/arch/x86/kernel/kvmclock.c
>>> @@ -107,12 +107,12 @@ static inline void kvm_sched_clock_init(bool stable)
>>> {
>>> if (!stable) {
>>> pv_time_ops.sched_clock = kvm_clock_read;
>>> + clear_sched_clock_stable();
>>> return;
>>> }
>>>
>>> kvm_sched_clock_offset = kvm_clock_read();
>>> pv_time_ops.sched_clock = kvm_sched_clock_read;
>>> - set_sched_clock_stable();
>>
>> This results in sched clock always unstable for kvm guest since there
>> is no invariant tsc cpuid bit exposed for kvm guest currently.
>
> What the heck is KVM_FEATURE_CLOCKSOURCE_STABLE_BIT /
> PVCLOCK_TSC_STABLE_BIT about then?
It checks that all the bugs in the host have been ironed out, and that
the host itself supports invtsc.
Paolo
next prev parent reply other threads:[~2017-02-27 12:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 7:31 Mike Galbraith
2017-01-19 10:19 ` Peter Zijlstra
2017-01-19 11:39 ` Mike Galbraith
2017-01-19 13:36 ` Peter Zijlstra
2017-01-19 16:54 ` Ingo Molnar
2017-01-19 17:20 ` Peter Zijlstra
2017-01-19 20:35 ` sched/clock: Fix hotplug issue kbuild test robot
2017-01-19 20:37 ` kbuild test robot
2017-01-20 6:36 ` [tip:sched/core] sched/clock: Fix hotplug crash tip-bot for Peter Zijlstra
2017-02-27 12:30 ` tip.today - scheduler bam boom crash (cpu hotplug) Wanpeng Li
2017-02-27 12:35 ` Paolo Bonzini
2017-02-27 12:43 ` Peter Zijlstra
2017-02-27 12:50 ` Paolo Bonzini [this message]
2017-02-27 13:04 ` Peter Zijlstra
2017-02-27 15:27 ` Paolo Bonzini
2017-02-27 15:59 ` Peter Zijlstra
2017-02-27 16:11 ` Paolo Bonzini
2017-02-27 16:36 ` Peter Zijlstra
2017-02-27 17:27 ` Paolo Bonzini
2017-02-27 17:40 ` Thomas Gleixner
2017-02-27 19:06 ` Paolo Bonzini
2017-02-27 20:35 ` Peter Zijlstra
2017-02-28 1:51 ` Wanpeng Li
2017-02-28 8:08 ` Peter Zijlstra
2017-02-28 8:11 ` Wanpeng Li
2017-03-01 13:39 ` Wanpeng Li
2017-03-01 14:17 ` Peter Zijlstra
2017-02-27 13:48 ` Wanpeng Li
2017-02-27 14:05 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e7c34e2-757b-19e9-f7e5-9bfaadd79e5d@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=kernellwp@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®