From: Daniel Vetter <daniel@ffwll.ch>
To: Rob Herring <robh+dt@kernel.org>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Frank Rowand <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Vincent Abriou <vincent.abriou@st.com>
Subject: Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate
Date: Mon, 27 Feb 2017 17:20:53 +0100 [thread overview]
Message-ID: <20170227162053.j2gca6zmobpengbb@phenom.ffwll.local> (raw)
In-Reply-To: <CAL_JsqJQcFO_=D=g1KrfSTQdVCXUfE0k25+PQnSxvLZ1pHU=3g@mail.gmail.com>
On Mon, Feb 27, 2017 at 07:30:24AM -0600, Rob Herring wrote:
> On Sun, Feb 26, 2017 at 2:11 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Fri, Feb 24, 2017 at 10:31:25AM -0600, Rob Herring wrote:
> >> On Fri, Feb 24, 2017 at 10:14 AM, Benjamin Gaignard
> >> <benjamin.gaignard@linaro.org> wrote:
> >> > Lots of calls to of_platform_populate() are not unbalanced by a call
> >> > to of_platform_depopulate(). This create issues while drivers are
> >> > bind/unbind.
> >> >
> >> > In way to solve those issues is to add devm_of_platform_populate()
> >> > which will call of_platform_depopulate() when the device is unbound
> >> > from the bus.
> >> >
> >> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> >> > ---
> >> > version 2:
> >> > - simplify function prototype to only keep device as parameter
> >> >
> >> > drivers/of/platform.c | 71 +++++++++++++++++++++++++++++++++++++++++++++
> >> > include/linux/of_platform.h | 11 +++++++
> >> > 2 files changed, 82 insertions(+)
> >>
> >> For this and patch 2:
> >>
> >> Acked-by: Rob Herring <robh@kernel.org>
> >
> > Is this an ack for merging both through drm-misc, or should we do a
> > topic-branch dance here?
>
> You can apply it directly.
Ok, this seems like a pretty cool idea, so applied both to drm-misc for
4.12.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-02-27 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 16:14 [PATCH v2 0/2] Introduce devm_of_platform_populate() helper Benjamin Gaignard
2017-02-24 16:14 ` [PATCH v2 1/2] of: add devm_ functions for populate and depopulate Benjamin Gaignard
2017-02-24 16:31 ` Rob Herring
2017-02-26 20:11 ` Daniel Vetter
2017-02-27 13:30 ` Rob Herring
2017-02-27 16:20 ` Daniel Vetter [this message]
2017-02-24 16:14 ` [PATCH v2 2/2] drm: sti: make driver use devm_of_platform_populate() Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227162053.j2gca6zmobpengbb@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®