mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sumantro <saggy.zone@gmail.com>
Cc: devel@driverdev.osuosl.org, vishali.thakkar@oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: removed unnecessary white lines from crtl_wx.c
Date: Tue, 28 Feb 2017 18:53:17 +0100	[thread overview]
Message-ID: <20170228175317.GA14128@kroah.com> (raw)
In-Reply-To: <20170228144625.GA18416@localhost.localdomain>

On Tue, Feb 28, 2017 at 08:16:25PM +0530, Sumantro wrote:
> staging:rtl8192e: removed extra whitelines which were giving warnings 
> Signed-off-by: Sumantro <saggy.zone@gmail.com>

We need a blank line before the signed-off-by line, as well as a
"real/full" name being used (unless you use only "Sumantro" on legal
documents.)

Also, you need to be a bit more verbose in the changelog text, no need
to repeat the driver and subsystem name, it's up there in the subject
line.

Look at other patches for the driver for examples of what needs to be
done here.

thanks,

greg k-h

      reply	other threads:[~2017-02-28 18:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 14:46 Sumantro
2017-02-28 17:53 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228175317.GA14128@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saggy.zone@gmail.com \
    --cc=vishali.thakkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome