* [PATCH] fix alloc_cast.cocci warnings
[not found] <201703060637.SQGYTNgP%fengguang.wu@intel.com>
@ 2017-03-05 22:42 ` kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2017-03-05 22:42 UTC (permalink / raw)
To: Sachin Prabhu
Cc: kbuild-all, linux-cifs, samba-technical, Steve French,
Pavel Shilovsky, linux-kernel
fs/cifs/smb2misc.c:689:14-41: WARNING: casting value returned by memory allocation function to (struct close_cancelled_open *) is useless.
Remove casting the values returned by memory allocation functions
like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.
Semantic patch information:
This makes an effort to find cases of casting of values returned by
kmalloc, kzalloc, kcalloc, kmem_cache_alloc, kmem_cache_zalloc,
kmem_cache_alloc_node, kmalloc_node and kzalloc_node and removes
the casting as it is not required. The result in the patch case may
need some reformatting.
Generated by: scripts/coccinelle/api/alloc/alloc_cast.cocci
CC: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
smb2misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/cifs/smb2misc.c
+++ b/fs/cifs/smb2misc.c
@@ -686,7 +686,7 @@ smb2_handle_cancelled_mid(char *buffer,
(sync_hdr->Status != STATUS_SUCCESS))
return 0;
- cancelled = (struct close_cancelled_open *)
+ cancelled =
kzalloc(sizeof(struct close_cancelled_open),
GFP_KERNEL);
if (!cancelled)
^ permalink raw reply [flat|nested] only message in thread