Re: [PATCH v7 1/6] ARM: dts: sun8i: drop skeleton.dtsi inclusion in H3 DTSI

Re: [PATCH v7 1/6] ARM: dts: sun8i: drop skeleton.dtsi inclusion in H3 DTSI

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi,

On Mon, Mar 06, 2017 at 07:31:33AM +0800, Icenowy Zheng wrote:
> The skeleton.dtsi file is now deprecated, and do not exist in ARM64
> environment.
> 
> Since we will soon reuse most part of H3 DTSI for H5, which is an ARM64
> chip, drop skeleton.dtsi inclusion now.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Your prefix (and in the three later patches) should be
ARM: sun8i: h3

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [linux-sunxi] Re: [PATCH v7 1/6] ARM: dts: sun8i: drop skeleton.dtsi inclusion in H3 DTSI

[Chen-Yu Tsai]

On Mon, Mar 6, 2017 at 6:46 PM, Icenowy Zheng <icenowy@aosc.xyz> wrote:
>
>
> 06.03.2017, 18:35, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
>> Hi,
>>
>> On Mon, Mar 06, 2017 at 07:31:33AM +0800, Icenowy Zheng wrote:
>>>  The skeleton.dtsi file is now deprecated, and do not exist in ARM64
>>>  environment.
>>>
>>>  Since we will soon reuse most part of H3 DTSI for H5, which is an ARM64
>>>  chip, drop skeleton.dtsi inclusion now.
>>>
>>>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>>
>> Your prefix (and in the three later patches) should be
>> ARM: sun8i: h3
>
> Oh I think we never added SoC name in prefix...

It's better to add them for sun8i, which encompasses a whole
bunch of SoCs, unlike the older sun[4-7]i. Even sun5i patches
have them.

ChenYu

Re: [PATCH v7 6/6] arm64: dts: sunxi: add support for the Orange Pi PC 2 board

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Mon, Mar 06, 2017 at 07:31:38AM +0800, Icenowy Zheng wrote:
> From: Andre Przywara <andre.przywara@arm.com>
> 
> The Orange Pi PC 2 is a typical single board computer using the
> Allwinner H5 SoC. Apart from the usual suspects it features three
> separately driven USB ports and a Gigabit Ethernet port.
> Also it has a SPI NOR flash soldered, from which the board can boot
> from. This enables the SBC to behave like a "real computer" with
> built-in firmware.
> 
> Add the board specific .dts file, which includes the H5 .dtsi and
> enables the peripherals that we support so far.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> [Icenowy: dropped all GPIO pinctrl nodes, change red LED gpio,
>  change MMC cd to active-low, rename some node names to prevent
>  underscores]
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

And here your prefix should be "arm64: allwinner: h5:"

(This also applies to your previous patch).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]