* [PATCH v1] locking/ww_mutex: Prevent read of uninitialized memory
@ 2017-03-07 16:54 Robert Foss
0 siblings, 0 replies; only message in thread
From: Robert Foss @ 2017-03-07 16:54 UTC (permalink / raw)
To: peterz, mingo, linux-kernel; +Cc: Robert Foss
abba.result is potentially uninitialized, but read during one
error condition.
On "missed ABBA deadlock" abba.result is read, but not initialized
in all situations.
Detected by CoverityScan, CID#1402035 ("Uninitialized scalar variable")
Signed-off-by: Robert Foss <robert.foss@collabora.com>
---
kernel/locking/test-ww_mutex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
index da6c9a34f62f..d11ad012bae6 100644
--- a/kernel/locking/test-ww_mutex.c
+++ b/kernel/locking/test-ww_mutex.c
@@ -196,7 +196,7 @@ static void test_abba_work(struct work_struct *work)
static int test_abba(bool resolve)
{
- struct test_abba abba;
+ struct test_abba abba = { 0 };
struct ww_acquire_ctx ctx;
int err, ret;
--
2.11.0.453.g787f75f05
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-07 16:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-07 16:54 [PATCH v1] locking/ww_mutex: Prevent read of uninitialized memory Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®