From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Jessica Yu <jeyu@redhat.com>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: make klp_mutex proper part of API
Date: Wed, 8 Mar 2017 07:06:19 -0600 [thread overview]
Message-ID: <20170308130619.3ixmcvw6rcy5od32@treble> (raw)
In-Reply-To: <alpine.LSU.2.20.1703081006420.31814@cbobk.fhfr.pm>
On Wed, Mar 08, 2017 at 10:16:00AM +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> klp_mutex is shared between core.c and transition.c, and as such would
> rather be properly located in livepatch.h so that we don't have to play
> 'extern' games from .c sources.
>
> This also silences sparse warning (wrongly) suggesting that klp_mutex
> should be defined static.
include/linux/livepatch.h is the public interface, whereas klp_mutex is
a private implementation detail. I think it would be a better fit in
kernel/livepatch/core.h (though that file doesn't yet exist).
--
Josh
next prev parent reply other threads:[~2017-03-08 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 9:16 Jiri Kosina
2017-03-08 11:31 ` Miroslav Benes
2017-03-08 13:06 ` Josh Poimboeuf [this message]
2017-03-08 13:10 ` Miroslav Benes
2017-03-08 13:27 ` [PATCH v2] " Jiri Kosina
2017-03-08 13:29 ` Miroslav Benes
2017-03-08 13:38 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308130619.3ixmcvw6rcy5od32@treble \
--to=jpoimboe@redhat.com \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®