* [PATCH v2 0/2] staging: speakup: checkpatch guided cleanups
@ 2017-03-10 10:50 Arushi Singhal
2017-03-10 10:50 ` [PATCH v2 1/2] staging: speakup: Placed Logical on the previous line Arushi Singhal
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arushi Singhal @ 2017-03-10 10:50 UTC (permalink / raw)
To: w.d.hubbs
Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup,
devel, linux-kernel, Arushi Singhal
Improve readability by fixing multiple checkpatch.pl
issues in speakup driver.
Arushi Singhal (2):
staging: speakup: Placed Logical on the previous line
staging: speakup: spaces preferred around operator
drivers/staging/speakup/main.c | 8 ++++----
drivers/staging/speakup/serialio.c | 4 ++--
drivers/staging/speakup/speakup.h | 12 ++++++------
drivers/staging/speakup/speakup_acntpc.c | 4 ++--
drivers/staging/speakup/speakup_decpc.c | 14 +++++++-------
drivers/staging/speakup/speakup_dtlk.c | 14 +++++++-------
drivers/staging/speakup/speakup_keypc.c | 12 ++++++------
drivers/staging/speakup/speakup_ltlk.c | 2 +-
8 files changed, 35 insertions(+), 35 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] staging: speakup: Placed Logical on the previous line 2017-03-10 10:50 [PATCH v2 0/2] staging: speakup: checkpatch guided cleanups Arushi Singhal @ 2017-03-10 10:50 ` Arushi Singhal 2017-03-10 10:50 ` [PATCH v2 2/2] staging: speakup: spaces preferred around operator Arushi Singhal [not found] ` <1c85204a-d45c-4374-a01c-0bca7e976f42@googlegroups.com> 2 siblings, 0 replies; 5+ messages in thread From: Arushi Singhal @ 2017-03-10 10:50 UTC (permalink / raw) To: w.d.hubbs Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup, devel, linux-kernel, Arushi Singhal Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/staging/speakup/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c index 6d9c9c858c75..00335eb2ff20 100644 --- a/drivers/staging/speakup/main.c +++ b/drivers/staging/speakup/main.c @@ -2159,10 +2159,10 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym, if (up_flag || spk_killed || type == KT_SHIFT) goto out; spk_shut_up &= 0xfe; - kh = (value == KVAL(K_DOWN)) - || (value == KVAL(K_UP)) - || (value == KVAL(K_LEFT)) - || (value == KVAL(K_RIGHT)); + kh = ((value == KVAL(K_DOWN)) || + (value == KVAL(K_UP)) || + (value == KVAL(K_LEFT)) || + (value == KVAL(K_RIGHT))); if ((cursor_track != read_all_mode) || !kh) if (!spk_no_intr) spk_do_flush(); -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] staging: speakup: spaces preferred around operator 2017-03-10 10:50 [PATCH v2 0/2] staging: speakup: checkpatch guided cleanups Arushi Singhal 2017-03-10 10:50 ` [PATCH v2 1/2] staging: speakup: Placed Logical on the previous line Arushi Singhal @ 2017-03-10 10:50 ` Arushi Singhal [not found] ` <1c85204a-d45c-4374-a01c-0bca7e976f42@googlegroups.com> 2 siblings, 0 replies; 5+ messages in thread From: Arushi Singhal @ 2017-03-10 10:50 UTC (permalink / raw) To: w.d.hubbs Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup, devel, linux-kernel, Arushi Singhal Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- changes in v2 - add the space where forgot to add drivers/staging/speakup/serialio.c | 4 ++-- drivers/staging/speakup/speakup.h | 12 ++++++------ drivers/staging/speakup/speakup_acntpc.c | 4 ++-- drivers/staging/speakup/speakup_decpc.c | 14 +++++++------- drivers/staging/speakup/speakup_dtlk.c | 14 +++++++------- drivers/staging/speakup/speakup_keypc.c | 12 ++++++------ drivers/staging/speakup/speakup_ltlk.c | 2 +- 7 files changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c index 657a48b6f8d3..aade52ee15a0 100644 --- a/drivers/staging/speakup/serialio.c +++ b/drivers/staging/speakup/serialio.c @@ -120,8 +120,8 @@ static void start_serial_interrupt(int irq) outb(UART_MCR_DTR | UART_MCR_RTS | UART_MCR_OUT2, speakup_info.port_tts + UART_MCR); /* Turn on Interrupts */ - outb(UART_IER_MSI|UART_IER_RLSI|UART_IER_RDI, - speakup_info.port_tts + UART_IER); + outb(UART_IER_MSI | UART_IER_RLSI | UART_IER_RDI, + speakup_info.port_tts + UART_IER); inb(speakup_info.port_tts + UART_LSR); inb(speakup_info.port_tts + UART_RX); inb(speakup_info.port_tts + UART_IIR); diff --git a/drivers/staging/speakup/speakup.h b/drivers/staging/speakup/speakup.h index 0bc8d6afadfa..a654334c98b9 100644 --- a/drivers/staging/speakup/speakup.h +++ b/drivers/staging/speakup/speakup.h @@ -20,7 +20,7 @@ #define A_CAP 0x0007 #define B_NUM 0x0008 #define NUM 0x0009 -#define ALPHANUM (B_ALPHA|B_NUM) +#define ALPHANUM (B_ALPHA | B_NUM) #define SOME 0x0010 #define MOST 0x0020 #define PUNC 0x0040 @@ -30,14 +30,14 @@ #define B_EXNUM 0x0100 #define CH_RPT 0x0200 #define B_CTL 0x0400 -#define A_CTL (B_CTL+SYNTH_OK) +#define A_CTL (B_CTL + SYNTH_OK) #define B_SYM 0x0800 -#define B_CAPSYM (B_CAP|B_SYM) +#define B_CAPSYM (B_CAP | B_SYM) /* FIXME: u16 */ -#define IS_WDLM(x) (spk_chartab[((u_char)x)]&B_WDLM) -#define IS_CHAR(x, type) (spk_chartab[((u_char)x)]&type) -#define IS_TYPE(x, type) ((spk_chartab[((u_char)x)]&type) == type) +#define IS_WDLM(x) (spk_chartab[((u_char)x)] & B_WDLM) +#define IS_CHAR(x, type) (spk_chartab[((u_char)x)] & type) +#define IS_TYPE(x, type) ((spk_chartab[((u_char)x)] & type) == type) int speakup_thread(void *data); void spk_reset_default_chars(void); diff --git a/drivers/staging/speakup/speakup_acntpc.c b/drivers/staging/speakup/speakup_acntpc.c index 56ece087ff88..cde77b75d44a 100644 --- a/drivers/staging/speakup/speakup_acntpc.c +++ b/drivers/staging/speakup/speakup_acntpc.c @@ -281,7 +281,7 @@ static int synth_probe(struct spk_synth *synth) if (port_val == 0x53fc) { /* 'S' and out&input bits */ synth_port_control = synth_portlist[i]; - speakup_info.port_tts = synth_port_control+1; + speakup_info.port_tts = synth_port_control + 1; break; } } @@ -304,7 +304,7 @@ static int synth_probe(struct spk_synth *synth) static void accent_release(void) { if (speakup_info.port_tts) - synth_release_region(speakup_info.port_tts-1, SYNTH_IO_EXTENT); + synth_release_region(speakup_info.port_tts - 1, SYNTH_IO_EXTENT); speakup_info.port_tts = 0; } diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index 4cd9730ee03d..afe2da34a3f7 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -249,7 +249,7 @@ static int dt_getstatus(void) static void dt_sendcmd(u_int cmd) { outb_p(cmd & 0xFF, speakup_info.port_tts); - outb_p((cmd >> 8) & 0xFF, speakup_info.port_tts+1); + outb_p((cmd >> 8) & 0xFF, speakup_info.port_tts + 1); } static int dt_waitbit(int bit) @@ -271,7 +271,7 @@ static int dt_wait_dma(void) if (!dt_waitbit(STAT_dma_ready)) return 0; while (--timeout > 0) { - if ((dt_getstatus()&STAT_dma_state) == state) + if ((dt_getstatus() & STAT_dma_state) == state) return 1; udelay(50); } @@ -317,8 +317,8 @@ udelay(50); break; udelay(50); } - outb_p(DMA_sync, speakup_info.port_tts+4); - outb_p(0, speakup_info.port_tts+4); + outb_p(DMA_sync, speakup_info.port_tts + 4); + outb_p(0, speakup_info.port_tts + 4); udelay(100); for (timeout = 0; timeout < 10; timeout++) { if (!(dt_getstatus() & STAT_flushing)) @@ -336,8 +336,8 @@ static int dt_sendchar(char ch) return -1; if (!(dt_stat & STAT_rr_char)) return -2; - outb_p(DMA_single_in, speakup_info.port_tts+4); - outb_p(ch, speakup_info.port_tts+4); + outb_p(DMA_single_in, speakup_info.port_tts + 4); + outb_p(ch, speakup_info.port_tts + 4); dma_state ^= STAT_dma_state; return 0; } @@ -353,7 +353,7 @@ static int testkernel(void) dt_sendcmd(CMD_sync); if (!dt_waitbit(STAT_cmd_ready)) status = -2; - else if (dt_stat&0x8000) + else if (dt_stat & 0x8000) return 0; else if (dt_stat == 0x0dec) pr_warn("dec_pc at 0x%x, software not loaded\n", diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c index de67288beb25..eede2d82183a 100644 --- a/drivers/staging/speakup/speakup_dtlk.c +++ b/drivers/staging/speakup/speakup_dtlk.c @@ -298,7 +298,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth) t += 2; for (i = 0; *t != '\r'; t++) { status.rom_version[i] = *t; - if (i < sizeof(status.rom_version)-1) + if (i < sizeof(status.rom_version) - 1) i++; } status.rom_version[i] = 0; @@ -333,13 +333,13 @@ static int synth_probe(struct spk_synth *synth) speakup_info.port_tts); if ((port_forced & 0xf) != 0xf) pr_info("warning: port base should probably end with f\n"); - if (synth_request_region(speakup_info.port_tts-1, - SYNTH_IO_EXTENT)) { + if (synth_request_region(speakup_info.port_tts - 1, + SYNTH_IO_EXTENT)) { pr_warn("sorry, port already reserved\n"); return -EBUSY; } - port_val = inw(speakup_info.port_tts-1); - synth_lpc = speakup_info.port_tts-1; + port_val = inw(speakup_info.port_tts - 1); + synth_lpc = speakup_info.port_tts - 1; } else { for (i = 0; synth_portlist[i]; i++) { if (synth_request_region(synth_portlist[i], @@ -348,7 +348,7 @@ static int synth_probe(struct spk_synth *synth) port_val = inw(synth_portlist[i]) & 0xfbff; if (port_val == 0x107f) { synth_lpc = synth_portlist[i]; - speakup_info.port_tts = synth_lpc+1; + speakup_info.port_tts = synth_lpc + 1; break; } synth_release_region(synth_portlist[i], @@ -375,7 +375,7 @@ static int synth_probe(struct spk_synth *synth) static void dtlk_release(void) { if (speakup_info.port_tts) - synth_release_region(speakup_info.port_tts-1, SYNTH_IO_EXTENT); + synth_release_region(speakup_info.port_tts - 1, SYNTH_IO_EXTENT); speakup_info.port_tts = 0; } diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c index 7c24e088549c..b802d6ce3941 100644 --- a/drivers/staging/speakup/speakup_keypc.c +++ b/drivers/staging/speakup/speakup_keypc.c @@ -141,9 +141,9 @@ static char *oops(void) int s1, s2, s3, s4; s1 = inb_p(synth_port); - s2 = inb_p(synth_port+1); - s3 = inb_p(synth_port+2); - s4 = inb_p(synth_port+3); + s2 = inb_p(synth_port + 1); + s3 = inb_p(synth_port + 2); + s4 = inb_p(synth_port + 3); pr_warn("synth timeout %d %d %d %d\n", s1, s2, s3, s4); return NULL; } @@ -241,7 +241,7 @@ spin_lock_irqsave(&speakup_info.spinlock, flags); delay_time_val = delay_time->u.n.value; spin_unlock_irqrestore(&speakup_info.spinlock, flags); schedule_timeout(msecs_to_jiffies(delay_time_val)); - jiff_max = jiffies+jiffy_delta_val; + jiff_max = jiffies + jiffy_delta_val; } } timeout = 1000; @@ -269,7 +269,7 @@ static int synth_probe(struct spk_synth *synth) synth_port = port_forced; pr_info("probe forced to %x by kernel command line\n", synth_port); - if (synth_request_region(synth_port-1, SYNTH_IO_EXTENT)) { + if (synth_request_region(synth_port - 1, SYNTH_IO_EXTENT)) { pr_warn("sorry, port already reserved\n"); return -EBUSY; } @@ -297,7 +297,7 @@ static int synth_probe(struct spk_synth *synth) return -ENODEV; } pr_info("%s: %03x-%03x, driver version %s,\n", synth->long_name, - synth_port, synth_port+SYNTH_IO_EXTENT-1, + synth_port, synth_port + SYNTH_IO_EXTENT - 1, synth->version); synth->alive = 1; return 0; diff --git a/drivers/staging/speakup/speakup_ltlk.c b/drivers/staging/speakup/speakup_ltlk.c index 9d22198a0339..c691382f9694 100644 --- a/drivers/staging/speakup/speakup_ltlk.c +++ b/drivers/staging/speakup/speakup_ltlk.c @@ -144,7 +144,7 @@ static void synth_interrogate(struct spk_synth *synth) if (i > 2 && buf[i] == 0x7f) break; } - t = buf+2; + t = buf + 2; for (i = 0; *t != '\r'; t++) { rom_v[i] = *t; if (++i >= 19) -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <1c85204a-d45c-4374-a01c-0bca7e976f42@googlegroups.com>]
* Re: [PATCH v2 0/2] staging: speakup: checkpatch guided cleanups [not found] ` <1c85204a-d45c-4374-a01c-0bca7e976f42@googlegroups.com> @ 2017-03-16 1:49 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2017-03-16 1:49 UTC (permalink / raw) To: Arushi Singhal Cc: outreachy-kernel, w.d.hubbs, chris, kirk, samuel.thibault, speakup, devel, linux-kernel On Wed, Mar 15, 2017 at 01:40:10AM -0700, Arushi Singhal wrote: > Hi > This Patch is also not yet added to the kernel-tree. I don't see it in my patch queue at all, so something must have gone wrong. Please rebase and resend them if they are still applicable. thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, @ 2017-03-19 13:14 Arushi Singhal 2017-03-19 13:14 ` [PATCH v2 2/2] staging: speakup: spaces preferred around operator Arushi Singhal 0 siblings, 1 reply; 5+ messages in thread From: Arushi Singhal @ 2017-03-19 13:14 UTC (permalink / raw) To: w.d.hubbs Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup, devel, linux-kernel, Arushi Singhal Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (2): staging: speakup: Moved OR operator to previous line. staging: speakup: spaces preferred around operator drivers/staging/speakup/main.c | 8 ++++---- drivers/staging/speakup/speakup.h | 12 ++++++------ drivers/staging/speakup/speakup_acntpc.c | 2 +- drivers/staging/speakup/speakup_decpc.c | 20 ++++++++++---------- drivers/staging/speakup/speakup_dtlk.c | 2 +- drivers/staging/speakup/speakup_keypc.c | 6 +++--- drivers/staging/speakup/speakup_ltlk.c | 2 +- 7 files changed, 26 insertions(+), 26 deletions(-) -- changes in v2 - correct the commit message of [PATCH 1/2] 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] staging: speakup: spaces preferred around operator 2017-03-19 13:14 [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Arushi Singhal @ 2017-03-19 13:14 ` Arushi Singhal 0 siblings, 0 replies; 5+ messages in thread From: Arushi Singhal @ 2017-03-19 13:14 UTC (permalink / raw) To: w.d.hubbs Cc: chris, outreachy-kernel, kirk, samuel.thibault, gregkh, speakup, devel, linux-kernel, Arushi Singhal Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- changes in v2 -no change. drivers/staging/speakup/speakup.h | 12 ++++++------ drivers/staging/speakup/speakup_acntpc.c | 2 +- drivers/staging/speakup/speakup_decpc.c | 20 ++++++++++---------- drivers/staging/speakup/speakup_dtlk.c | 2 +- drivers/staging/speakup/speakup_keypc.c | 6 +++--- drivers/staging/speakup/speakup_ltlk.c | 2 +- 6 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/speakup/speakup.h b/drivers/staging/speakup/speakup.h index 0bc8d6afadfa..a654334c98b9 100644 --- a/drivers/staging/speakup/speakup.h +++ b/drivers/staging/speakup/speakup.h @@ -20,7 +20,7 @@ #define A_CAP 0x0007 #define B_NUM 0x0008 #define NUM 0x0009 -#define ALPHANUM (B_ALPHA|B_NUM) +#define ALPHANUM (B_ALPHA | B_NUM) #define SOME 0x0010 #define MOST 0x0020 #define PUNC 0x0040 @@ -30,14 +30,14 @@ #define B_EXNUM 0x0100 #define CH_RPT 0x0200 #define B_CTL 0x0400 -#define A_CTL (B_CTL+SYNTH_OK) +#define A_CTL (B_CTL + SYNTH_OK) #define B_SYM 0x0800 -#define B_CAPSYM (B_CAP|B_SYM) +#define B_CAPSYM (B_CAP | B_SYM) /* FIXME: u16 */ -#define IS_WDLM(x) (spk_chartab[((u_char)x)]&B_WDLM) -#define IS_CHAR(x, type) (spk_chartab[((u_char)x)]&type) -#define IS_TYPE(x, type) ((spk_chartab[((u_char)x)]&type) == type) +#define IS_WDLM(x) (spk_chartab[((u_char)x)] & B_WDLM) +#define IS_CHAR(x, type) (spk_chartab[((u_char)x)] & type) +#define IS_TYPE(x, type) ((spk_chartab[((u_char)x)] & type) == type) int speakup_thread(void *data); void spk_reset_default_chars(void); diff --git a/drivers/staging/speakup/speakup_acntpc.c b/drivers/staging/speakup/speakup_acntpc.c index c5beb5602c42..b4058bd82e42 100644 --- a/drivers/staging/speakup/speakup_acntpc.c +++ b/drivers/staging/speakup/speakup_acntpc.c @@ -282,7 +282,7 @@ static int synth_probe(struct spk_synth *synth) if (port_val == 0x53fc) { /* 'S' and out&input bits */ synth_port_control = synth_portlist[i]; - speakup_info.port_tts = synth_port_control+1; + speakup_info.port_tts = synth_port_control + 1; break; } } diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index 5e35d7e11361..5d22c3b7edd4 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -250,7 +250,7 @@ static int dt_getstatus(void) static void dt_sendcmd(u_int cmd) { outb_p(cmd & 0xFF, speakup_info.port_tts); - outb_p((cmd >> 8) & 0xFF, speakup_info.port_tts+1); + outb_p((cmd >> 8) & 0xFF, speakup_info.port_tts + 1); } static int dt_waitbit(int bit) @@ -286,11 +286,11 @@ static int dt_ctrl(u_int cmd) if (!dt_waitbit(STAT_cmd_ready)) return -1; - outb_p(0, speakup_info.port_tts+2); - outb_p(0, speakup_info.port_tts+3); + outb_p(0, speakup_info.port_tts + 2); + outb_p(0, speakup_info.port_tts + 3); dt_getstatus(); - dt_sendcmd(CMD_control|cmd); - outb_p(0, speakup_info.port_tts+6); + dt_sendcmd(CMD_control | cmd); + outb_p(0, speakup_info.port_tts + 6); while (dt_getstatus() & STAT_cmd_ready) { udelay(20); if (--timeout == 0) @@ -318,8 +318,8 @@ udelay(50); break; udelay(50); } - outb_p(DMA_sync, speakup_info.port_tts+4); - outb_p(0, speakup_info.port_tts+4); + outb_p(DMA_sync, speakup_info.port_tts + 4); + outb_p(0, speakup_info.port_tts + 4); udelay(100); for (timeout = 0; timeout < 10; timeout++) { if (!(dt_getstatus() & STAT_flushing)) @@ -337,8 +337,8 @@ static int dt_sendchar(char ch) return -1; if (!(dt_stat & STAT_rr_char)) return -2; - outb_p(DMA_single_in, speakup_info.port_tts+4); - outb_p(ch, speakup_info.port_tts+4); + outb_p(DMA_single_in, speakup_info.port_tts + 4); + outb_p(ch, speakup_info.port_tts + 4); dma_state ^= STAT_dma_state; return 0; } @@ -354,7 +354,7 @@ static int testkernel(void) dt_sendcmd(CMD_sync); if (!dt_waitbit(STAT_cmd_ready)) status = -2; - else if (dt_stat&0x8000) + else if (dt_stat & 0x8000) return 0; else if (dt_stat == 0x0dec) pr_warn("dec_pc at 0x%x, software not loaded\n", diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c index 693fac4365c3..5973acc0a006 100644 --- a/drivers/staging/speakup/speakup_dtlk.c +++ b/drivers/staging/speakup/speakup_dtlk.c @@ -300,7 +300,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth) t += 2; for (i = 0; *t != '\r'; t++) { status.rom_version[i] = *t; - if (i < sizeof(status.rom_version)-1) + if (i < sizeof(status.rom_version) - 1) i++; } status.rom_version[i] = 0; diff --git a/drivers/staging/speakup/speakup_keypc.c b/drivers/staging/speakup/speakup_keypc.c index 6649fa4c0ad2..ba7901178e0b 100644 --- a/drivers/staging/speakup/speakup_keypc.c +++ b/drivers/staging/speakup/speakup_keypc.c @@ -142,9 +142,9 @@ static char *oops(void) int s1, s2, s3, s4; s1 = inb_p(synth_port); - s2 = inb_p(synth_port+1); - s3 = inb_p(synth_port+2); - s4 = inb_p(synth_port+3); + s2 = inb_p(synth_port + 1); + s3 = inb_p(synth_port + 2); + s4 = inb_p(synth_port + 3); pr_warn("synth timeout %d %d %d %d\n", s1, s2, s3, s4); return NULL; } diff --git a/drivers/staging/speakup/speakup_ltlk.c b/drivers/staging/speakup/speakup_ltlk.c index cb4f2958c318..11275f49bea4 100644 --- a/drivers/staging/speakup/speakup_ltlk.c +++ b/drivers/staging/speakup/speakup_ltlk.c @@ -145,7 +145,7 @@ static void synth_interrogate(struct spk_synth *synth) if (i > 2 && buf[i] == 0x7f) break; } - t = buf+2; + t = buf + 2; for (i = 0; *t != '\r'; t++) { rom_v[i] = *t; if (++i >= 19) -- 2.11.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-19 13:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 10:50 [PATCH v2 0/2] staging: speakup: checkpatch guided cleanups Arushi Singhal
2017-03-10 10:50 ` [PATCH v2 1/2] staging: speakup: Placed Logical on the previous line Arushi Singhal
2017-03-10 10:50 ` [PATCH v2 2/2] staging: speakup: spaces preferred around operator Arushi Singhal
[not found] ` <1c85204a-d45c-4374-a01c-0bca7e976f42@googlegroups.com>
2017-03-16 1:49 ` [PATCH v2 0/2] staging: speakup: checkpatch guided cleanups Greg KH
2017-03-19 13:14 [PATCH v2 0/2] staging:speakup: Multiple checkpatch issues, Arushi Singhal
2017-03-19 13:14 ` [PATCH v2 2/2] staging: speakup: spaces preferred around operator Arushi Singhal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome