* [PATCH v1] x86/platform/intel-mid: Correct MSI for watchdog device
@ 2017-03-12 15:07 Andy Shevchenko
2017-03-13 7:15 ` [tip:x86/urgent] x86/platform/intel-mid: Correct MSI IRQ line " tip-bot for Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2017-03-12 15:07 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, linux-kernel
Cc: Andy Shevchenko, David Cohen
The interrupt line used for watchdog is 12 according to the official
Intel Edison BSP code.
And indeed after fixing it we start getting an interrupt and thus:
[ 191.699951] Kernel panic - not syncing: Kernel Watchdog
Fixes: 78a3bb9e408b ("x86: intel-mid: add watchdog platform code for Merrifield")
Cc: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c b/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
index 86edd1e941eb..9e304e2ea4f5 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
@@ -19,7 +19,7 @@
#include <asm/intel_scu_ipc.h>
#include <asm/io_apic.h>
-#define TANGIER_EXT_TIMER0_MSI 15
+#define TANGIER_EXT_TIMER0_MSI 12
static struct platform_device wdt_dev = {
.name = "intel_mid_wdt",
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip:x86/urgent] x86/platform/intel-mid: Correct MSI IRQ line for watchdog device
2017-03-12 15:07 [PATCH v1] x86/platform/intel-mid: Correct MSI for watchdog device Andy Shevchenko
@ 2017-03-13 7:15 ` tip-bot for Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Andy Shevchenko @ 2017-03-13 7:15 UTC (permalink / raw)
To: linux-tip-commits
Cc: bp, david.a.cohen, peterz, tglx, mingo, torvalds, linux-kernel,
hpa, andriy.shevchenko
Commit-ID: 80354c29025833acd72ddac1ffa21c6cb50128cd
Gitweb: http://git.kernel.org/tip/80354c29025833acd72ddac1ffa21c6cb50128cd
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Sun, 12 Mar 2017 17:07:44 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 13 Mar 2017 08:11:57 +0100
x86/platform/intel-mid: Correct MSI IRQ line for watchdog device
The interrupt line used for the watchdog is 12, according to the official
Intel Edison BSP code.
And indeed after fixing it we start getting an interrupt and thus the
watchdog starts working again:
[ 191.699951] Kernel panic - not syncing: Kernel Watchdog
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: David Cohen <david.a.cohen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 78a3bb9e408b ("x86: intel-mid: add watchdog platform code for Merrifield")
Link: http://lkml.kernel.org/r/20170312150744.45493-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c b/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
index 86edd1e9..9e304e2 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_mrfld_wdt.c
@@ -19,7 +19,7 @@
#include <asm/intel_scu_ipc.h>
#include <asm/io_apic.h>
-#define TANGIER_EXT_TIMER0_MSI 15
+#define TANGIER_EXT_TIMER0_MSI 12
static struct platform_device wdt_dev = {
.name = "intel_mid_wdt",
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-13 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-12 15:07 [PATCH v1] x86/platform/intel-mid: Correct MSI for watchdog device Andy Shevchenko
2017-03-13 7:15 ` [tip:x86/urgent] x86/platform/intel-mid: Correct MSI IRQ line " tip-bot for Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome